Repository navigation
fix(models): wait for another process's download on Windows - #1753
Merged
Merged
Conversation
kitlangton
force-pushed
the
windows-download-lock
branch
from
November 12, 2026 21:41
7ba7b59 to
2b6a223
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, a model download now waits for one another process is already running instead of failing at once.
This also fixes
waiting_for_another_processs_download_reports_its_partial_bytes, which has failed on every Windows check run since #1735 added it.❌ Before
hex model installis downloading a model in a terminal (or another Hex is).ERROR_LOCK_VIOLATION, which Rust'siodoesn't map toWouldBlock, so Hex took it as a real failure: the download failed rather than waiting, and deleting a model during a download failed with a raw OS error instead of "A model download is in progress".✅ After
WouldBlockorERROR_LOCK_VIOLATION), so Windows waits and shows the other process's progress, as macOS and Linux did.👀 Read: nothing tricky;
meeting.rs'slock_contendedmoved todurable.rsunchanged so models and meetings share it.Checks run
scripts/check transcription::models meeting(macOS): 383 passedcheck-windows.ymlon this branch: passed on x64 and ARM64, https://github.com/anomalyco/hex/actions/runs/43303190525 (ARM64 needed one rerun: an unrelated Authenticode test timed out)