Skip to content

PHP 8.6 | Tests: further changes to handle a change in error message format - #222

Open
antecedent wants to merge 5 commits into
masterfrom
php86-error-messages-in-tests
Open

PHP 8.6 | Tests: further changes to handle a change in error message format#222
antecedent wants to merge 5 commits into
masterfrom
php86-error-messages-in-tests

Conversation

@antecedent

Copy link
Copy Markdown
Owner

This is meant to bring #217 to completion. I merged that one prematurely; the test case had not been passing.

@antecedent
antecedent requested a review from jrfnl August 19, 2026 14:15
@jrfnl

jrfnl commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

@antecedent Interesting. I'd run the tests locally on Windows with PHP 8.6-beta1 with a php.ini based on the php.ini-development file and the tests were passing fine.
And while I'm writing this, I remember that shivammathur/setup-php uses the php.ini-production file as default, so it makes total sense that the ini values for the settings being changed in this PR would be turned off for production.

In other words, an alternative solution would probably be to add ini-file: development to the with section of the Setup PHP step.

Not sure what you would prefer ?

@antecedent

Copy link
Copy Markdown
Owner Author

@jrfnl, I think that is great! I do prefer having the php.ini values set in a more across-the-board way. But it was not enough to set ini-file: development; I ended up adding the setting to ini-values separately. That is still an improvement to me. But I wonder how come you got a different default from the php.ini-development on your local setup 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants