Repository navigation
perf(cmake): reduce output registry reconciliation work - #52
Merged
Merged
Conversation
Keep the registry lock through single-plan commits and authenticate retained claim and plan records once per reconciliation batch. Project overlap inputs once per comparison, combine Windows link metadata probes, and reject file/link/junction replacements during physical identity reads without retaining filesystem observations across comparisons. Add bounded path-free progress diagnostics on stderr, expose them through CMake, and keep the stdout claim-token protocol intact. Add an offline scaling benchmark and regressions for operation counts, ownership races, physical aliases, path replacement, and live diagnostics. Document benchmark use and reconciliation progress. Validation: 1708 default tests passed, 41 skipped; 15 coordinator/CMake tests passed, 1 skipped; Ruff and whitespace checks passed. Three alternating Windows/Python 3.12.9 samples per case reduced median reconciliation wall time by 90.8% (8 claims/4 plans) and 91.9% (16 claims/4 plans).
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50.
Reconciling several output plans rescans and reloads the retained registry for each plan, while overlap checks repeatedly project the same paths. This reduces that repeated work and makes slow reconciliation report its current phase.
Measured against
ca3200bfc8b4cecbfb7fc4d45f2cac85919bdd33on Windows with CPython 3.12.9. These are median reconciliation wall times from three alternating baseline/candidate samples per case; registry seeding is timed separately and excluded.Both cases reduce registry scans from 4 to 1. Recorded-plan loads during validation fall from 32 to 8 and 64 to 16; path projections during validation fall from 9,820 to 481 and 18,716 to 913, respectively. Filesystem caches, path depth, and machine activity affect wall times; these workstation results are not a CI performance guarantee.
To reproduce with a checkout of the baseline revision at
../protocyte-baseline:Validation:
python -m pytest -q -n 4: 1,708 passed, 41 skipped.python -m pytest -q -m cmake_integration tests/test_output_coordinator_cmake.py: 15 passed, 1 skipped.ruff check src tests cmake/ProtocyteOutputCoordinator.py: passed.git diff --check: passed.Local verification was on Windows; cross-platform CI remains to run.