Repository navigation
fix(cmake): preserve nested pip-bootstrap diagnostics - #53
Merged
Merged
Conversation
Run venv through a small wrapper that catches bootstrap subprocess failures before the standard CLI discards their captured output. Preserve the selected interpreter, isolation, platform defaults, timeout, and existing rollback path. Redact URLs before truncation, remove control characters, bound each captured stream to 16,384 characters, and report the original child exit status without printing the child command or environment. Install the helper with the CMake package, document the diagnostic behavior, and cover real nested child failures, missing modules, rollback refusal, credential redaction, and successful environment creation. Extend the Windows Python 3.12-3.14 CI matrix with the new regressions. Validated focused tests on Windows with Python 3.12 and 3.14, normal and relocated-install provisioning, transaction/documentation tests, Ruff, and the private-path guard. Fixes #51
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pip bootstrapping fails inside Python's
venvCLI, the CLI can discard the child's captured output and leave CMake with only a generic subprocess error. A small wrapper now calls the samevenventry point and surfaces that diagnostic before the existing rollback and CMake error path.Validation performed locally on Windows:
git diff --check, and the private-path guard passed.Fixes #51.