Repository navigation
fix: passwordless sudo preflight and dnsutils check; add demo GIF - #3
Merged
Merged
Conversation
…hout one On Debian the default %sudo rule requires a password, so `sudo -v` prompts even when agbox's NOPASSWD rule also matches. Re-running setup without a terminal (e.g. from an agent) then failed with 'sudo authentication failed'.
On Debian 13 dnsutils is only a virtual package provided by bind9-dnsutils, so dpkg never reports it installed and doctor always failed on it.
Recorded with vhs from docs/assets/demo.tape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes found while recording a demo GIF:
%sudorule requires a password, sosudo -vprompts even when agbox's NOPASSWD rule also matches. Re-runningagbox setupwithout a terminal (for example from an agent) failed withsudo authentication failed. Preflight now triessudo -n truefirst. A new CLI test uses a fakesudoto cover this. It also fixes 3 dry-run CLI tests that failed on hosts set up this way.bind9-dnsutilsinstead of the virtualdnsutils. On Debian 13,dnsutilsexists only as a name provided bybind9-dnsutils, so dpkg never reports it as installed andagbox doctoralways failed on it.bind9-dnsutilsis the real package name on Debian 12/13 and Ubuntu 24.04+.agbox doctordemo GIF to the README, recorded with vhs fromdocs/assets/demo.tape.make checkpasses locally.