Repository navigation
feat!: install the full stable Matt Pocock skill set - #2
Merged
Merged
Conversation
BREAKING CHANGE: the wizard's "Select AI engineering workflow" prompt and the --spec-workflow flag are gone. Every standard skill installs by default, so there was nothing left to select. Skills: - Install all 27 stable Matt Pocock skills (engineering + productivity) instead of the tdd / code-review / diagnosing-bugs trio. The misc and in-progress buckets stay out. - Upgrade saved configs that still hold an old default skill selection, and drop the retired skills.workflow field. Hand-narrowed lists are preserved. - AGENTS.md lists the full standard set and the spec workflow, understands wildcard sources, and separates its sections with blank lines again. Wording: - Replace T3 Code references with generic AI coding agent wording. Toolchain: - TypeScript 7, Vitest 5, Commander 15, tsx 4.23, pnpm 12.10. @types/node stays on the 22.x line so the types match engines >= 22.12.0. - pnpm typecheck now type-checks tests/ via tsconfig.test.json. - Version is read from package.json in the CLI and the smoke test; bump to 0.2.0 with a changelog. Fixes: - aginit doctor no longer warns when skills are disabled in config, and reports on-disk skills even when the lockfile records none. - aginit init in the current directory no longer prints "cd .". - Ignore graft's .ignore ripgrep hint alongside /graft/. Additions: - pnpm check:skills and a weekly Skill drift workflow that fails when a standard skill disappears upstream or a new stable skill is published.
macos-latest failed on both Node versions: process.cwd() returns the symlink-resolved path there (/var -> /private/var), so handing createProject the raw os.tmpdir() path did not compare equal to cwd and the cd step was legitimately printed. Drive the target with process.cwd(), which is canonical everywhere, and match the next-steps line with a regex after stripping ANSI so the assertion also works when CI renders colors.
antomanc
added a commit
that referenced
this pull request
Oct 10, 2026
* feat!: install the full stable Matt Pocock skill set BREAKING CHANGE: the wizard's "Select AI engineering workflow" prompt and the --spec-workflow flag are gone. Every standard skill installs by default, so there was nothing left to select. Skills: - Install all 27 stable Matt Pocock skills (engineering + productivity) instead of the tdd / code-review / diagnosing-bugs trio. The misc and in-progress buckets stay out. - Upgrade saved configs that still hold an old default skill selection, and drop the retired skills.workflow field. Hand-narrowed lists are preserved. - AGENTS.md lists the full standard set and the spec workflow, understands wildcard sources, and separates its sections with blank lines again. Wording: - Replace T3 Code references with generic AI coding agent wording. Toolchain: - TypeScript 7, Vitest 5, Commander 15, tsx 4.23, pnpm 12.10. @types/node stays on the 22.x line so the types match engines >= 22.12.0. - pnpm typecheck now type-checks tests/ via tsconfig.test.json. - Version is read from package.json in the CLI and the smoke test; bump to 0.2.0 with a changelog. Fixes: - aginit doctor no longer warns when skills are disabled in config, and reports on-disk skills even when the lockfile records none. - aginit init in the current directory no longer prints "cd .". - Ignore graft's .ignore ripgrep hint alongside /graft/. Additions: - pnpm check:skills and a weekly Skill drift workflow that fails when a standard skill disappears upstream or a new stable skill is published. * test: make the cd-step assertion platform-independent macos-latest failed on both Node versions: process.cwd() returns the symlink-resolved path there (/var -> /private/var), so handing createProject the raw os.tmpdir() path did not compare equal to cwd and the cd step was legitimately printed. Drive the target with process.cwd(), which is canonical everywhere, and match the next-steps line with a regex after stripping ANSI so the assertion also works when CI renders colors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three requested changes plus a cleanup pass over the issues they surfaced.
Skills — all stable Matt Pocock skills are now standard
engineering+productivity) instead of thetdd/code-review/diagnosing-bugstrio. Themiscandin-progressbuckets stay out; upstream'sdeprecatedbucket is currently empty.--spec-workflowflag — with everything installed there was nothing left to select.skills.workflowis no longer written, but is still read so existing configs load untouched.upgradeLegacySkillConfig(); a hand-narrowed list is preserved as written. Verified end-to-end: a legacy config comes out with 27 skills, noworkflow, and itsextensionfield intact.Wording
package.jsondescription/keywords, CLI description, next-steps line,README.md,AGENTS.md).Versions → current
engines >= 22.12.0)TS7 no longer auto-includes ambient
@types, sotsconfig.jsongained"types": ["node"].Issues found and fixed along the way
AGENTS.md—.filter((s) => s !== '')deleted the deliberate separators along with empty capability bullets. Conditional lines now emitundefined;''survives as a separator. Regression-tested.package.json; the README dropped the literal (the npm badge already shows it).tsconfig.test.json+ a chainedtsc --noEmit, picked up automatically by CI's existingpnpm typecheck. It caught 2 real errors intests/git.test.tson first run.@types/nodeahead of the support floor — pinned to the 22.x line so types matchenginesand the CI matrix. (Alternative: raiseenginesto>=24, drop22.xfrom the matrix, use^24.)cd .next-step when initializing the current directory.aginit doctorwarned about missing skills even when--no-skillsdisabled them, and an emptyskills-lock.jsonhid skills installed by hand —getInstalledSkills()now reports the union of lockfile and disk..ignoreartifact written bygraft build— ignored here and in the generatedDEFAULT_GITIGNORE.pnpm check:skills+ a weeklySkill driftworkflow fail when a standard skill is renamed/deleted/moved out of a stable category, or when a new stable skill appears.Verification
pnpm check→ typecheck (src+tests), 78 tests, build, audit — green.pnpm smoke→ packed-tarball consumer projects,--version=0.2.0.pnpm check:skills→All 27 standard skills verified (38 published, 27 in stable categories); failure path verified with an injected bogus skill (exit 1).aginit newrun → 28 skills landed in.agents/skills/; generatedAGENTS.mdhas correct blank-line separation.graft buildrefreshed.