Repository navigation
perf: skip unused Safe Inventory pass in managed manifests - #133
Open
dayebishouji wants to merge 1 commit into
Open
dayebishouji wants to merge 1 commit into
dayebishouji wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a managed-scope repository,
businesssource.Buildbuilt a Safe Inventory and then calledmanagedstate.Load, which built another one. The first inventory was never read by the managed branch. Build the standalone inventory only for the legacy branch; managed manifests still use the validated inventory and fingerprints from managed state. The final Overview source guard is unchanged.Refs #127. This is a small reduction in server-side work, not a claim to resolve the full first-session latency reported in the issue.
Validation:
source manifest --jsonoutput before and after was byte-for-byte identical (409,172 bytes).before, after, after, before) returned the same index SHA, six chunks, and 219,413 response bytes. Median first-Overview time was 3.656 s before and 2.604 s after; median time for all six chunks was 20.471 s before and 16.022 s after. These are two runs per build on a warm Windows filesystem cache, so they measure this fixture rather than a general speedup guarantee.verifyandcheckpassed with no drift; the Code Entry and Baseline were updated.go vet ./...passed.go test ./... -count=1passed all packages except two Windows failures (internal/cli's initial Guide text assertion andinternal/codebatch's unwritable-directory assertion); both exact tests fail the same way on an untouchedorigin/maincheckout. The focusedbusinesssourceandvolumegovernancepackages passed.