Skip to content

Implement IN CQL for dataset_group - #344

Merged
shaunahu merged 1 commit into
mainfrom
feature/8536-group-in
Sep 4, 2026
Merged

Implement IN CQL for dataset_group#344
shaunahu merged 1 commit into
mainfrom
feature/8536-group-in

Conversation

@utas-raymondng

@utas-raymondng utas-raymondng commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

The previous implementation of equals for dataset group is incorrect.

  1. dataset_group = xxx should match dataset_group : ['xxx'] not dataset_group : ['xxx', 'yyyy]
  2. dataset group IN ('xxx') should match dataset_group : ['xxx', 'yyyy] or dataset_group : ['xxx']

shaunahu
shaunahu approved these changes Sep 4, 2026
View reviewed changes

@shaunahu shaunahu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaunahu
shaunahu merged commit 11c1cf3 into main Sep 4, 2026
4 checks passed
@shaunahu
shaunahu deleted the feature/8536-group-in branch September 4, 2026 05:58

This branch was successfully deployed

1 active deployment
test — d5c542ec Deployed Sep 4, 2026 by utas-raymondng via build_test #837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shaunahu shaunahu shaunahu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@utas-raymondng @shaunahu