Adds property for Thrift Selector threads - #6529
Merged
ddanielr merged 5 commits intoSep 10, 2026
Merged
Conversation
getNumThreads was only being used by the BulkImport code and have a hardcoded default value. Refactored the method to pass in a default value to allow for more use in the code. Added test cases.
Allows the selector thread counts to be set via property value. This property was added under the `general.rpc` prefix as it can be different across instances in the same accumulo cluster.
dlmarion
reviewed
Sep 9, 2026
Co-authored-by: Dave Marion <dlmarion@apache.org>
Remove the needless default value passing and rely on the behavior of configuration.get(). Keep the value checks so an invalid config results in process failure.
dlmarion
approved these changes
Sep 10, 2026
dlmarion
left a comment
dlmarion
left a comment
Contributor
There was a problem hiding this comment.
I think this looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a property to configure the number of selector threads for the TThreadedSelector thrift server type.
2is used as the default value since that was the lower bound in the old calculation.I did not use the
general.rpc.server.optsprefix pattern since the ThriftServerTypes are a set list and not pluggable.accumulo/server/base/src/main/java/org/apache/accumulo/server/rpc/ThriftServerType.java
Lines 32 to 37 in 2253a2b
Tested and confirmed that the logging message changes on startup