[AMORO-1523][AMS] Auto-install discovered plugins when no plugin configs exist - #4347
Open
zhang-arvin wants to merge 1 commit into
Open
[AMORO-1523][AMS] Auto-install discovered plugins when no plugin configs exist#4347zhang-arvin wants to merge 1 commit into
zhang-arvin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixes #1523: When starting AMS in IntelliJ IDEA, the Local Optimizer cannot be started because the
execute-engines.yamlplugin configuration file is missing from the default IDE setup.Root Cause
AbstractPluginManager.initialize()discovers plugins via ServiceLoader but then only installs those with matching YAML configurations. When started from an IDE without theplugins/config directory, no configurations are loaded, so discovered plugins likeLocalExecutionEngineare never installed.Fix
When
loadPluginConfigurations()returns an empty list butfoundAvailablePlugins()has discovered plugins, auto-create default configurations for all discovered plugins. This ensures the Local Optimizer works out-of-the-box in IDE development environments.How was this patch tested?
emptyConfig()method already exists inPluginConfigurationfor this purpose