Skip to content

chore(javascript): format packages after we run napi - #4959

Merged
lidavidm merged 1 commit into
apache:mainfrom
amoeba:release/utils-prepare-napi-format
Oct 26, 2026
Merged

lidavidm merged 1 commit into
apache:mainfrom
amoeba:release/utils-prepare-napi-format

Conversation

@amoeba

@amoeba amoeba commented Oct 26, 2026

Copy link
Copy Markdown
Member

In #4954 we saw the Lint/CheckJS job fail:

Checking formatting...
[warn] npm/darwin-arm64/package.json
[warn] npm/darwin-x64/package.json
[warn] npm/linux-arm64-gnu/package.json
[warn] npm/linux-x64-gnu/package.json
[warn] npm/win32-arm64-msvc/package.json
[warn] npm/win32-x64-msvc/package.json
[warn] Code style issues found in 6 files. Run Prettier with --write to fix.
Error: Process completed with exit code 1.

In dev/release/utils-prepare.sh we run npx --yes napi version which, when it writes out new package.json files, doesn't add trailing newlines. I think we should reformat after we run napi so this PR adds an npm run fix after we run napi version so the result of napi passes our lint step.

@amoeba
amoeba requested review from kou and lidavidm as code owners October 26, 2026 22:22
@lidavidm lidavidm changed the title release(javascript): format packages after we run napi chore(javascript): format packages after we run napi Oct 26, 2026
@lidavidm
lidavidm merged commit 6c1bf4a into apache:main Oct 26, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants