Repository navigation
fix(csharp): prevent freeing driver library twice - #4976
Merged
Merged
Conversation
Member
Author
|
CI should fail on Windows on a9edd1e. |
Member
Author
|
From https://github.com/apache/arrow-adbc/actions/runs/40781480559/job/123143975815?pr=4976 The error isn't a direct check but hopefully the way the test is structured makes this make sense. |
amoeba
marked this pull request as ready for review
October 28, 2026 22:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
CAdbcDriverImporter.Loadis called withcanUnload: trueand the library doesn't export the requested entrypoint, the netstandard2.0 build (used on .NET Framework) frees the library twice: once before throwing and again in thefinallyblock. That build uses its ownNativeLibraryshim, whoseGetExportreturnsIntPtr.Zerofor a missing export instead of throwing, so it reaches a branch the net8.0/net10.0 builds never do. Freeing twice can unload a library that something else in the process still uses.This PR adds a test for this case and leaves freeing the library to the
finallyblock.Bug found and PR created with Opus 5.5.