Repository navigation
fix(csharp): try fallback entrypoint on .NET Framework - #4977
Merged
CurtHagenlocher merged 2 commits intoOct 28, 2026
Merged
Conversation
Member
Author
|
Windows CI should fail for 0d42b93. |
Member
Author
|
Windows CI failed as expected in https://github.com/apache/arrow-adbc/actions/runs/40782252801/job/123146586705?pr=4977: |
amoeba
marked this pull request as ready for review
October 28, 2026 22:59
CurtHagenlocher
approved these changes
Oct 28, 2026
CurtHagenlocher
left a comment
Contributor
There was a problem hiding this comment.
Well, that was an embarrassing lack of test coverage on my part :/. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no entrypoint is specified, the driver manager tries the entrypoint derived from the driver's file name (e.g.
AdbcDriverSqliteInit) and then falls back toAdbcDriverInit. On the netstandard2.0 build (used on .NET Framework), the fallback was never tried: that build uses its ownNativeLibraryshim, whoseGetExportreturnsIntPtr.Zerofor a missing export instead of throwingEntryPointNotFoundException, and the fallback only ran when an exception was thrown. So on .NET Framework, a driver that exports onlyAdbcDriverInitfailed to load with "Unable to find ... export", while the same driver loaded fine on .NET 8 and later.This PR adds a test for this case and tries the fallback entrypoint whether the first lookup throws or returns
IntPtr.Zero.Bug found and PR created with Opus 5.5.