Repository navigation
fix(rust/driver_manager): align driver and manifest loading errors with c++ - #4993
Merged
Merged
Conversation
amoeba
marked this pull request as ready for review
November 3, 2026 21:58
lidavidm
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Rust driver manager search code to return errors and error details that match what C++ and C# do.
Each test covers a case and the table below describes what changed at high level:
test_load_from_name_missing_or_invalid_driverInternalNotFound, with the path in the errortest_manifest_wrong_archInvalidArgumentsNotFound, with more detail in the errortest_load_dynamic_missing_driverInternalNotFound, with the path in the errortest_empty_driver_nameNotFoundInvalidArguments, with a clear error messagetest_load_from_name_invalid_manifest_by_path_or_nameInvalidArgumentsby path,NotFoundby nameInvalidArgumentseither way, and the error includes the manifest pathtest_relative_driver_path_disallowedInvalidArgumentsInvalidArguments, and the error now includes the pathThis PR makes the Rust column in the table on #4973 match the other columns.
Continuation of:
This PR was created by driving Opus 5.5 around. I reviewed it with GPT Sol 6.1 and Opus 5.5 and reviewed the tests myself.