Skip to content

fix(rust/driver_manager): align driver and manifest loading errors with c++ - #4993

Merged
lidavidm merged 1 commit into
apache:mainfrom
amoeba:rust-explicit-path-not-found
Nov 4, 2026
Merged

lidavidm merged 1 commit into
apache:mainfrom
amoeba:rust-explicit-path-not-found

Conversation

@amoeba

@amoeba amoeba commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Updates the Rust driver manager search code to return errors and error details that match what C++ and C# do.

Each test covers a case and the table below describes what changed at high level:

Test Before After
test_load_from_name_missing_or_invalid_driver Internal NotFound, with the path in the error
test_manifest_wrong_arch InvalidArguments NotFound, with more detail in the error
test_load_dynamic_missing_driver Internal NotFound, with the path in the error
test_empty_driver_name NotFound InvalidArguments, with a clear error message
test_load_from_name_invalid_manifest_by_path_or_name InvalidArguments by path, NotFound by name InvalidArguments either way, and the error includes the manifest path
test_relative_driver_path_disallowed InvalidArguments InvalidArguments, and the error now includes the path

This PR makes the Rust column in the table on #4973 match the other columns.

Continuation of:

This PR was created by driving Opus 5.5 around. I reviewed it with GPT Sol 6.1 and Opus 5.5 and reviewed the tests myself.

@amoeba amoeba changed the title fix(rust): align driver and manifest loading errors with c++ fix(rust/driver_manager): align driver and manifest loading errors with c++ Nov 3, 2026
@amoeba
amoeba marked this pull request as ready for review November 3, 2026 21:58
@amoeba
amoeba requested a review from wjones127 as a code owner November 3, 2026 21:58
@amoeba
amoeba requested a review from lidavidm November 3, 2026 21:58
@lidavidm
lidavidm merged commit a185032 into apache:main Nov 4, 2026
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants