Repository navigation
Conversation
Drivers may export buffers that only meet the C Data Interface's recommended 8-byte alignment, but arrow-rs requires 16-byte alignment for i128 (e.g. Decimal128). With arrow 58, importing such data through `from_ffi` or `ArrowArrayStreamReader` panics. arrow 59 realigns under-aligned buffers on import (apache/arrow-rs#10030), so raise the minimum arrow version to 59 and add a regression test that imports an 8-byte-aligned Decimal128 buffer. Closes apache#2526. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
I have no rush in merging this because it bumps the minimum Arrow requirement. It's really just a test and documentation of this problem we had in |
This was referenced Nov 7, 2026
Member
|
I think I held back for a bit because of DataFusion. That said, 58.x still seems to get patch releases (it was included in the round of updates two weeks ago). Based on apache/arrow-rs#10349 it seems to be because Comet is still on 58.x. |
Member
|
Hmm, but they've since upgraded (apache/datafusion-comet@75fdddc). I think we may as well go ahead. |
lidavidm
requested changes
Nov 8, 2026
Comment on lines
+39
to
+41
| # arrow >= 59 realigns under-aligned buffers imported through the C Data | ||
| # Interface (arrow-rs#10030). Older versions panic on buffers that are only | ||
| # 8-byte aligned (e.g. Decimal128 from JVM-based drivers). |
Member
There was a problem hiding this comment.
Suggested change
| # arrow >= 59 realigns under-aligned buffers imported through the C Data | |
| # Interface (arrow-rs#10030). Older versions panic on buffers that are only | |
| # 8-byte aligned (e.g. Decimal128 from JVM-based drivers). |
I don't see why this needs to be called out all over the place.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drivers may export buffers that only meet the C Data Interface's recommended 8-byte alignment (and sometimes not even that), but arrow-rs requires 16-byte alignment for i128 (e.g. Decimal128). With arrow 58, importing such data through
from_ffiorArrowArrayStreamReaderpanics.arrow 59 realigns under-aligned buffers on import (apache/arrow-rs#10030), so raise the minimum arrow version to 59 and add a regression test that imports an 8-byte-aligned Decimal128 buffer.
Closes #2526.