Repository navigation
benchmark: Add Boolean filter kernel benchmarks - #11980
Closed
Rich-T-kid wants to merge 1 commit into
Closed
Rich-T-kid wants to merge 1 commit into
Rich-T-kid wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
arrow-core
Rich-T-kid
marked this pull request as ready for review
October 29, 2026 03:13
Rich-T-kid
added
the
development-process
Rich-T-kid
changed the title
Contributor
Author
|
Superseded by #12054, which combines this with the related benchmark coverage. |
dwsmith1983
pushed a commit
to dwsmith1983/arrow-rs
that referenced
this pull request
Nov 4, 2026
# Which issue does this PR close? Part of apache#11885. Adds benchmark coverage for apache#11901 and apache#12008, and follows up on the Boolean filter coverage requested in [apache#11918](apache#11918 (comment)). This consolidates and supersedes apache#11980 and apache#12041. # Why is this change needed? The existing suites do not cover Boolean arrays as filter data or the cost of operating on small key ranges backed by oversized dictionaries. They also do not exercise the 16-values-per-selected-key boundary between dense and sparse dictionary mappings. # What changes are included in this PR? - Adds nullable and non-null Boolean filter cases across the existing selectivities. - Adds prepared `RowConverter` cases for rotating 8,192-key ranges backed by unique string dictionaries with 1M and 4M values. - Measures the full-value encoding cost from apache#11901 without including `RowConverter` construction. - Adds concat cases for 12 distinct dictionaries sliced to 682 keys, with 12, 16, and 24 values per selected key. - Straddles apache#12008's 16-values-per-selected-key cutoff so we can assess the threshold. # Are these changes tested? Built and ran each filtered benchmark locally. Benchmark bot runs: - [`filter_kernels`](apache#12054 (comment)) - [`row_format`](apache#12054 (comment)) - [`concatenate_kernel`](apache#12054 (comment)) # Are there any significant user-facing changes? No. This only adds benchmark coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to this review comment on #11918.
Adds Boolean data to
filter_kernels, covering nullable and non-null arrays across the existing selectivities. Previously it only used Boolean arrays as filter masks.