Skip to content

Add row dictionary slice benchmarks - #12041

Closed
Rich-T-kid wants to merge 1 commit into
apache:mainfrom
Rich-T-kid:bench-row-dictionary-slices-11901
Closed

Rich-T-kid wants to merge 1 commit into
apache:mainfrom
Rich-T-kid:bench-row-dictionary-slices-11901

Conversation

@Rich-T-kid

@Rich-T-kid Rich-T-kid commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Adds benchmarks for #11901.

They convert rotating 8,192-key ranges from unique string dictionaries with 1M and 4M values, reusing a prepared RowConverter and timing only convert_columns. This exposes the current behavior where each small conversion re-encodes the full values array.

@Rich-T-kid
Rich-T-kid force-pushed the bench-row-dictionary-slices-11901 branch from 5afca4f to 1a5a052 Compare November 3, 2026 04:06
@Rich-T-kid

Copy link
Copy Markdown
Contributor Author

@alamb could you stamp 🙇

@github-actions github-actions Bot added the arrow-core Core crates related to representing arrow data label Nov 3, 2026
@Rich-T-kid
Rich-T-kid force-pushed the bench-row-dictionary-slices-11901 branch from 1a5a052 to 6a8c160 Compare November 3, 2026 04:10
@Rich-T-kid

Copy link
Copy Markdown
Contributor Author

run benchmark row_format
env:
BENCH_FILTER: "convert_columns_prepared 8192 string_dictionary"

@adriangbot

Copy link
Copy Markdown

🤖 Benchmark starting (GKE) | trigger

Target: row_format

Sharding factor: 1 (1 workers).

Comparing bench-row-dictionary-slices-11901 (6a8c160) to b231cf1 (merge-base) diff

Run configuration
run benchmark row_format
env:
  BENCH_FILTER: convert_columns_prepared 8192 string_dictionary
shards: 1

Results will be posted when all workers finish.


File an issue against this benchmark runner

@adriangbot

Copy link
Copy Markdown

🤖 Benchmark completed (GKE) | trigger

Target: row_format

Comparing bench-row-dictionary-slices-11901 (6a8c160) to b231cf1 (merge-base) diff

Run configuration
run benchmark row_format
env:
  BENCH_FILTER: convert_columns_prepared 8192 string_dictionary
shards: 1
Details
group                                                              changed
-----                                                              -------
convert_columns_prepared 8192 string_dictionary(1000000 values)    1.00      6.7±0.03ms        ? ?/sec
convert_columns_prepared 8192 string_dictionary(4000000 values)    1.00     67.2±0.43ms        ? ?/sec

Per-runner information
row_format — shard 1/1

Node: gk3-benchmark-cluster-nap-o8oe52el-122737a1-l6bj

Instance: c4a-highmem-16 (12 vCPU / 65 GiB)

uname:

Linux bench-c6595253362-4298-m2lps 6.12.105+ #1 SMP Sat Sep 19 07:55:25 UTC 2026 aarch64 GNU/Linux

BENCH_COMMAND:

cargo bench --features=arrow,async,test_common,experimental,object_store --bench row_format
CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected
Resource Usage

base (merge-base)

Metric Value
Wall time 5.0s
Peak memory 5.8 MiB
Avg memory 984.0 KiB
CPU user 0.0s
CPU sys 0.0s
Peak spill 0 B

branch

Metric Value
Wall time 25.0s
Peak memory 221.7 MiB
Avg memory 78.6 MiB
CPU user 13.0s
CPU sys 6.0s
Peak spill 0 B

File an issue against this benchmark runner

@Rich-T-kid Rich-T-kid added the development-process Internal changes; PRs with this label are excluded from changelog label Nov 3, 2026
@Rich-T-kid

Copy link
Copy Markdown
Contributor Author

Superseded by #12054, which combines this with the related benchmark coverage.

@Rich-T-kid Rich-T-kid closed this Nov 3, 2026
dwsmith1983 pushed a commit to dwsmith1983/arrow-rs that referenced this pull request Nov 4, 2026
# Which issue does this PR close?

Part of apache#11885. Adds benchmark coverage for apache#11901 and apache#12008, and
follows up on the Boolean filter coverage requested in
[apache#11918](apache#11918 (comment)).

This consolidates and supersedes apache#11980 and apache#12041.

# Why is this change needed?

The existing suites do not cover Boolean arrays as filter data or the
cost of operating on small key ranges backed by oversized dictionaries.
They also do not exercise the 16-values-per-selected-key boundary
between dense and sparse dictionary mappings.

# What changes are included in this PR?

- Adds nullable and non-null Boolean filter cases across the existing
selectivities.
- Adds prepared `RowConverter` cases for rotating 8,192-key ranges
backed by unique string dictionaries with 1M and 4M values.
- Measures the full-value encoding cost from apache#11901 without including
`RowConverter` construction.
- Adds concat cases for 12 distinct dictionaries sliced to 682 keys,
with 12, 16, and 24 values per selected key.
- Straddles apache#12008's 16-values-per-selected-key cutoff so we can assess
the threshold.

# Are these changes tested?

Built and ran each filtered benchmark locally.

Benchmark bot runs:

-
[`filter_kernels`](apache#12054 (comment))
-
[`row_format`](apache#12054 (comment))
-
[`concatenate_kernel`](apache#12054 (comment))

# Are there any significant user-facing changes?

No. This only adds benchmark coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow-core Core crates related to representing arrow data development-process Internal changes; PRs with this label are excluded from changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants