Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigQuery Storage Write API writers remove rejected payloads and timestamps before retrying a batch, but leave failsafe rows in their original positions. When
withFormatRecordOnFailureFunctionis set, a later serialization error can select the wrong original row for the failure output, duplicating one record and omitting another.This change filters failsafe rows alongside payloads and timestamps in both writers. Nullable entries used for protobuf-to-TableRow fallback are preserved. The API defines row-error indexes relative to the current request.
Local regression validation passed with controlled append responses. A recorded live BigQuery run also reproduced the misattribution after a partial row-error response. That response size was observed in the run and is not an API guarantee.
Run the GCP module tests with:
addresses #123orfixes #456).CHANGES.mdwith noteworthy changes.See CONTRIBUTING.md for contribution guidelines.