Skip to content

reduce LeaderBoardIT flakiness #40241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damccorm merged 6 commits into from
Sep 29, 2026
Merged

reduce LeaderBoardIT flakiness #40241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
72d8762
reduce LeaderBoardIT flakiness
aIbrahiim Sep 23, 2026
106a047
increase timeout
aIbrahiim Sep 24, 2026
eb0dc9f
add wait for PubSub publish
aIbrahiim Sep 24, 2026
f184031
trigger workflow
aIbrahiim Sep 24, 2026
a6f9865
trigger workflow
aIbrahiim Sep 28, 2026
4a88188
wait for PubSub subscription readiness
aIbrahiim Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/trigger_files/beam_PostCommit_Python.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run.",
"pr": "40139",
"modification": 59
"pr": "40241",
"modification": 63
}
25 changes: 20 additions & 5 deletions sdks/python/apache_beam/examples/complete/game/leader_board_it_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ class LeaderBoardIT(unittest.TestCase):
OUTPUT_TABLE_TEAMS = 'leader_board_teams'
DEFAULT_INPUT_COUNT = 500

WAIT_UNTIL_FINISH_DURATION = 10 * 60 * 1000 # in milliseconds
WAIT_UNTIL_FINISH_DURATION = 15 * 60 * 1000 # in milliseconds
# Poll BigQuery after the pipeline wait; streaming inserts can lag.
BQ_MATCHER_TIMEOUT_SECS = 10 * 60

def setUp(self):
self.test_pipeline = TestPipeline(is_integration_test=True)
Expand All @@ -84,6 +86,8 @@ def setUp(self):
name=self.sub_client.subscription_path(
self.project, self.INPUT_SUB + _unique_id),
topic=self.input_topic.name)
# New subscriptions can miss messages published immediately after create.
time.sleep(30)

# Set up BigQuery environment
self.dataset_ref = utils.create_bq_dataset(
Expand All @@ -97,9 +101,14 @@ def _inject_pubsub_game_events(self, topic, message_count):
logging.debug(
'Injecting %d game events to topic %s', message_count, topic.name)

publish_futures = []
for _ in range(message_count):
self.pub_client.publish(
topic.name, (self.INPUT_EVENT % self._test_timestamp).encode('utf-8'))
publish_futures.append(
self.pub_client.publish(
topic.name,
(self.INPUT_EVENT % self._test_timestamp).encode('utf-8')))
for future in publish_futures:
future.result()

def _cleanup_pubsub(self):
test_utils.cleanup_subscriptions(self.sub_client, [self.input_sub])
Expand All @@ -124,7 +133,10 @@ def test_leader_board_it(self):
self.OUTPUT_TABLE_USERS,
success_condition))
bq_users_verifier = BigqueryMatcher(
self.project, users_query, self.DEFAULT_EXPECTED_CHECKSUM)
self.project,
users_query,
self.DEFAULT_EXPECTED_CHECKSUM,
timeout_secs=self.BQ_MATCHER_TIMEOUT_SECS)

teams_query = (
'SELECT total_score FROM `%s.%s.%s` '
Expand All @@ -134,7 +146,10 @@ def test_leader_board_it(self):
self.OUTPUT_TABLE_TEAMS,
success_condition))
bq_teams_verifier = BigqueryMatcher(
self.project, teams_query, self.DEFAULT_EXPECTED_CHECKSUM)
self.project,
teams_query,
self.DEFAULT_EXPECTED_CHECKSUM,
timeout_secs=self.BQ_MATCHER_TIMEOUT_SECS)

extra_opts = {
'allow_unsafe_triggers': True,
Expand Down
Loading