[prodriguezdefino]

First change in the series that adds the Apache Beam Rust SDK.

This change adds:

• The Cargo workspace at sdks/rust (rustfmt and clippy configuration, workspace lints, dev profiles) with a single member.
• apache-beam-model: protobuf and gRPC bindings generated at build time from the model protos in this repository (model/pipeline, model/fn-execution, model/job-management).
• Gradle integration (:sdks:rust), so the SDK builds like the rest of the repository: build, check (rustfmt + clippy -D warnings), test, fmt and clean. build.gradle applies one script per build area from sdks/rust/gradle/; the tasks call cargo, which handles incremental builds. Gradle passes the Beam version from gradle.properties to cargo; no Beam version is hard-coded in the Rust sources.
• Release tooling: release/src/main/scripts/set_version.sh bumps the Cargo manifests through sdks/rust/scripts/set_version.sh.
• local-env-setup.sh installs Rust and protoc.
• README.md and docs/development.md.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.90%. Comparing base (76f6e6d) to head (f9338b3).
⚠️ Report is 319 commits behind head on master.

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #40508       +/-   ##
=============================================
+ Coverage     56.16%   79.90%   +23.73%     
=============================================
  Files          1124      493      -631     
  Lines        178336    83473    -94863     
  Branches       1489        0     -1489     
=============================================
- Hits         100170    66699    -33471     
+ Misses        75645    16774    -58871     
+ Partials       2521        0     -2521     

Flag	Coverage Δ
go	?
java	?
python	79.90% <ø> (+0.34%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[CH-Abhinav]

Hey @prodriguezdefino, I would like to help this PR as much as possible since I didn't know Beam is getting a Rust SDK. I am new to beam and I am excited to see Rust based work here.

I tested this branch locally on Windows with rustc 1.98 and protoc 36.0 — cargo check built cleanly and all proto/gRPC definitions generated without issues.

One small note: building on Windows requires protoc in PATH (or setting the PROTOC environment variable). Would it be helpful to add a quick mention in docs/development.md regarding installing protoc on Windows (e.g., via winget install Google.Protobuf or manual binary download)?

Happy to help test upcoming PRs on Windows or contribute to the downstream crates as the SDK progresses.

[prodriguezdefino]

Thanks for testing this out on Windows @CH-Abhinav, great to hear cargo check and proto generation worked cleanly!

In Beam, host dependencies are normally set up via local-env-setup.sh or by using the Dockerized development environment via start-build-env.sh at the root of the repository, rather than listing per-OS installation steps in each SDK's docs.

Once the RFC document (it's on the dev@ distro if you're curious about it) gets reviewed and hopefully, eventually approved, I planned to start working on having the initial PRs land. This draft is more about making sure checks are in place for once/if things get in motion.

It would be great to have your help making sure things work smoothly on Windows!

[prodriguezdefino]

/gemini review

[github-actions]

📋 Review Summary

This PR cleanly scaffolds the new Apache Beam Rust SDK workspace (sdks/rust), Gradle integration (:sdks:rust), release version tooling, and the apache-beam-model crate for compiling portability Protobuf and gRPC definitions. The structure is well-organized and follows Beam's repository conventions.

🔍 General Feedback

• Environment Setup (local-env-setup.sh): While protoc was added to the macOS setup path, it is currently missing from the Linux setup path (dev-support/docker/pkglist does not include protobuf-compiler).
• Release Script (release/src/main/scripts/set_version.sh): The git add 'sdks/rust/*Cargo.toml' pathspec only matches single-depth subdirectories in Git, which misses crate manifests nested deeper such as sdks/rust/beam/model/Cargo.toml.

---

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

[prodriguezdefino]

/gemini review

[github-actions]

📋 Review Summary

This PR cleanly sets up the initial Cargo workspace, Gradle build integration (:sdks:rust), version-bumping scripts, environment setup, and the apache-beam-model crate with generated Protobuf/gRPC bindings. All feedback from the previous review (adding protobuf-compiler to dev-support/docker/pkglist for Linux setups and resolving the broken link in README.md) has been addressed.

🔍 General Feedback

• The Gradle-to-Cargo task delegation (build, check, test, fmt, clean) and version propagation from gradle.properties integrate smoothly with existing Beam build and release conventions.
• Protobuf compilation in beam/model/build.rs properly registers cargo:rerun-if-changed directives for all model proto inputs.

---

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

[CH-Abhinav]

/gemini review

[github-actions]

📋 Review Summary

This PR cleanly bootstraps the Apache Beam Rust SDK workspace (:sdks:rust), providing the initial apache-beam-model crate with prost/tonic protobuf and gRPC code generation alongside Gradle task integration and version management scripts. The workspace structure, crate re-exports, and developer documentation are well-organized and align well with existing multi-language SDK conventions in the repository.

🔍 General Feedback

• The apache-beam-model crate setup in build.rs and src/lib.rs neatly encapsulates the deep protobuf package hierarchy behind a private org module while exposing flat pipeline, fn_execution, job_management, and expansion modules.
• A couple of minor edge cases in sdks/rust/scripts/set_version.sh and sdks/rust/gradle/cargo.gradle around dependency attribute ordering and empty Gradle property handling are worth tightening.

---

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

[prodriguezdefino]

/gemini review

[github-actions]

📋 Review Summary

This PR introduces the initial foundation for the Apache Beam Rust SDK under sdks/rust, including Cargo workspace setup (beam, beam-proto, beam-worker), tonic/prost protobuf generation for the Beam Runner/Fn/Job APIs, Gradle integration, and release version scripts.

🔍 General Feedback

• The overall structure of the Rust workspace and beam-proto build script is clean and idiomatic.
• There are a couple of issues in the Gradle task wiring (test lifecycle task not wired to cargoTest) and the shell script logic (local-env-setup.sh operator precedence bug on Linux, and set_version.sh failure when Cargo.lock is gitignored/absent).

---

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

💬 Inline Findings

• local-env-setup.sh (line 71): 🟠 High: In Bash, && has higher precedence than ||. In command -v rustup && rustup update || curl ..., if rustup is already installed (command -v rustup succeeds) and rustup update fails (e.g., due to a transient network issue or toolchain error), the || branch will execute and re-run the rustup.rs installer script. Additionally, when rustup is freshly installed via curl ... | sh -s -- -y, ~/.cargo/env is not sourced in the current shell session, so subsequent commands in the same session won't find cargo or rustup on PATH (and on macOS at line 159, rustup-init -y is interactive unless invoked or flags are passed appropriately, or rustup update is run).

    if command -v rustup >/dev/null 2>&1; then rustup update; else curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y; fi

• sdks/rust/build.gradle.kts (line 68): 🟠 High: org.apache.beam.module only applies the Gradle base plugin by default (unless a language nature is applied), which defines check and build, but not a test task. Here, tasks.register("test") registers an empty lifecycle task that does not depend on cargoTest. Running ./gradlew :sdks:rust:test will therefore succeed without running any Rust tests.

tasks.register("test") { dependsOn(cargoTest) }

• sdks/rust/scripts/set_version.sh (line 53): 🟠 High: sdks/rust/Cargo.lock is ignored in .gitignore and not tracked in the repository. When release/src/main/scripts/set_version.sh invokes this script on a clean checkout where cargo has not been run (or if cargo is not installed on the machine running the version bump script), sdks/rust/Cargo.lock will not exist and sed -i ... "$SCRIPT_DIR/../Cargo.lock" will fail under set -e (and git add sdks/rust/Cargo.lock in release/src/main/scripts/set_version.sh will also fail due to .gitignore). Guard the Cargo.lock update with an existence check or only update Cargo.toml files.

if [[ -f "$SCRIPT_DIR/../Cargo.lock" ]]; then sed -i -e '/name = "apache-beam/,/version =/{s/version = .*/version = "'"$TARGET_VERSION"'"/;}' "$SCRIPT_DIR/../Cargo.lock"; fi

• sdks/rust/beam-proto/build.rs (line 57): 🟡 Medium: Only emitting cargo:rerun-if-changed for the parent directory (proto_root) only watches the directory entry itself, not modifications to .proto files inside nested subdirectories (org/apache/beam/model/...). Iterating over proto_files and emitting cargo:rerun-if-changed={proto_file} ensures Cargo recompiles the crate whenever any .proto definition is modified.

    for proto in &proto_files { println!("cargo:rerun-if-changed={}", proto.display()); }

• sdks/rust/Cargo.toml (line 31): 🟢 Low: The repository URL points to the personal fork https://github.com/robertwb/beam instead of the canonical https://github.com/apache/beam repository.

repository = "https://github.com/apache/beam"