Skip to content

Fix Release NightlySnapshot after enabling errorprone for Java17+ build - #40668

Open
Abacn wants to merge 1 commit into
apache:masterfrom
Abacn:fix-errorprone-j17
Open

Abacn wants to merge 1 commit into
apache:masterfrom
Abacn:fix-errorprone-j17

Conversation

@Abacn

@Abacn Abacn commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor
  • Suppress PatternMatchingInstanceof in DeltaLakeIO test

Fix #38899

R: @aIbrahiim

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates DeltaWriteTestUtils.java to use pattern matching for instanceof (val instanceof java.time.Instant inst), resolving the PatternMatchingInstanceof ErrorProne check failure on Java 17+ builds that caused the Release Nightly Snapshot workflow to fail.

🔍 General Feedback

  • The change is clean, minimal, and valid since :sdks:java:io:delta explicitly requires Java 17 (requireJavaVersion: JavaVersion.VERSION_17).

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (76f6e6d) to head (208f50c).
⚠️ Report is 242 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #40668       +/-   ##
=============================================
- Coverage     56.16%        0   -56.17%     
=============================================
  Files          1124        0     -1124     
  Lines        178336        0   -178336     
  Branches       1489        0     -1489     
=============================================
- Hits         100170        0   -100170     
+ Misses        75645        0    -75645     
+ Partials       2521        0     -2521     
Flag Coverage Δ
go ?
java ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

* Suppress PatternMatchingInstanceof in DeltaLakeIO test
@Abacn
Abacn force-pushed the fix-errorprone-j17 branch from b3c50cb to 208f50c Compare October 20, 2026 00:06
@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @ahmedabu98 for label delta.
Backup reviewer: chamikaramj (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Release Nightly Snapshot job is flaky

2 participants