Repository navigation
Upgrade google-api-client to 2.7.2 and use bomupgrade to manage - #40670
Merged
Merged
Conversation
google_clients_version (2.0.0) was used both as the google-api-client version and as the google-api-services-* artifact suffix. Because Beam forces library versions, google-api-client was pinned to 2.0.0, while current generated clients and libraries-bom require 2.7.2. Split it into google_api_client_version (2.7.2) and google_api_services_version_suffix (2.0.0).
Abacn
reviewed
Oct 19, 2026
| def gax_version = "2.84.0" | ||
| def google_ads_version = "33.0.0" | ||
| def google_clients_version = "2.0.0" | ||
| def google_api_client_version = "2.7.2" |
Contributor
There was a problem hiding this comment.
Let's add a [bomupgrader] comment to opt in to bomupgrader
Collaborator
Author
There was a problem hiding this comment.
Sure, we can do that after the tests are green.
Collaborator
Author
There was a problem hiding this comment.
Done in the latest commit.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40670 +/- ##
=============================================
+ Coverage 56.16% 75.97% +19.80%
+ Complexity 2288 2273 -15
=============================================
Files 1124 259 -865
Lines 178336 14377 -163959
Branches 1489 1479 -10
=============================================
- Hits 100170 10923 -89247
+ Misses 75645 2763 -72882
+ Partials 2521 691 -1830
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shunping
marked this pull request as ready for review
October 19, 2026 23:55
shunping
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
google_clients_version (2.0.0) was used both as the google-api-client version and as the google-api-services-* artifact suffix. Because Beam forces library versions, google-api-client was pinned to 2.0.0, while current generated clients and libraries-bom require 2.7.2.
Split it into google_api_client_version (2.7.2) and google_api_services_version_suffix (2.0.0).
Part of #40569