Skip to content

Fix bigquery_tools_test to mock gcp_bigquery library instead... #40676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chamikaramj merged 1 commit into from
Oct 20, 2026
Merged

Fix bigquery_tools_test to mock gcp_bigquery library instead... #40676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions sdks/python/apache_beam/io/gcp/bigquery_tools_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1697,15 +1697,17 @@ def request(self, uri, method='GET', body=None, headers=None, **kwargs):
for headers in token_request_headers:
self.assertNotIn('x-goog-user-project', headers)

@mock.patch('apache_beam.io.gcp.bigquery_tools.gcp_bigquery.Client')
def test_gcp_bigquery_client_passes_quota_project(self, mock_client):
@mock.patch('apache_beam.io.gcp.bigquery_tools.gcp_bigquery')
def test_gcp_bigquery_client_passes_quota_project(self, mock_gcp_bq):
mock_client = mock_gcp_bq.Client
BigQueryWrapper._gcp_bigquery_client(quota_project_id='my-billing-project')
self.assertEqual(
mock_client.call_args.kwargs['client_options'],
{'quota_project_id': 'my-billing-project'})

@mock.patch('apache_beam.io.gcp.bigquery_tools.gcp_bigquery.Client')
def test_gcp_bigquery_client_no_quota_project_by_default(self, mock_client):
@mock.patch('apache_beam.io.gcp.bigquery_tools.gcp_bigquery')
def test_gcp_bigquery_client_no_quota_project_by_default(self, mock_gcp_bq):
mock_client = mock_gcp_bq.Client
BigQueryWrapper._gcp_bigquery_client()
self.assertIsNone(mock_client.call_args.kwargs['client_options'])

Expand Down
Loading