Repository navigation
Stable code identifier pickling - #40711
Draft
kristynsmith wants to merge 14 commits into
Draft
kristynsmith wants to merge 14 commits into
kristynsmith wants to merge 14 commits into
Conversation
Replace config assignment with dataclasses.replace for stability.
Refactor code object handling and improve normalization for hashing.
Added new test cases for lambda functions and decorators in code_object_pickler.
Refactor code object search logic to handle local code objects and update lambda handling. Replace lambda-specific functions with more general object handling functions.
Added tests for handling same-named nested functions with different and same arguments in code object pickler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several edge cases in
code_object_picklerwhen generating and resolving stable code object identifiers:deffunctions have the same name (e.g. defined acrossif/elsebranches) by applying the same signature and bytecode-hash disambiguation in_search_locals(formerly_search_lambda) to any duplicate code object name inco_consts, and updating_OBJECT_WITH_ARGS_PATTERNand_OBJECT_WITH_HASH_PATTERNto match named functions in addition to<lambda>._OBJECT_WITH_ARGS_PATTERNto match empty argument tuples().co_codebytecode instructions (e.g. referencing different closure variables or constants) by includingco_consts,co_names,co_varnames,co_freevars, andco_cellvarsin_create_bytecode_hash.from pkg.submod import submodinpkg/__init__.py) by resolving the longest matching module prefix inget_code_from_identifierbefore traversing attributes.None(falling back to default pickling) instead of raisingValueError('Qual name parts too long')when a branch does not match the full__qualname__.