Skip to content

TPC-DS suite follow ups - #40741

Merged
Abacn merged 2 commits into
apache:masterfrom
Abacn:fix-tpcds-py
Oct 23, 2026
Merged

Abacn merged 2 commits into
apache:masterfrom
Abacn:fix-tpcds-py

Conversation

@Abacn

@Abacn Abacn commented Oct 23, 2026

Copy link
Copy Markdown
Contributor
  • Some 10 MB test failed due to filtered dataset has no result, either intermediate or final query result, and may cause ZeroDivision, etc. Fixed dataset to add more items so they query result has non-zero row

  • Fix known error to check whole error stack instead of the first line

  • Fix log spam on Flink and Spark runners

  • Enable query90,98

* Some 10 MB test failed due to filtered dataset has no result, either
  intermediate or final query result, and may cause ZeroDivision, etc.
  Fixed dataset to add more items so they query result has non-zero row

* Fix known error to check whole error stack instead of the first line

* Fix log spam on Flink and Spark runners

* Enable query90,98

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates the TPC-DS benchmark suite in Java and Python to enable queries 90 and 98, suppress excessive runner log spam on Flink and Spark via logging configuration files, and preserve the full error stack trace in TpcdsQueryResult for regression checks while still summarizing errors in the printed table.

🔍 General Feedback

  • Preserving the full exception string in TpcdsQueryResult.error_message while moving the single-line extraction to format_summary_table is a good improvement for making verify_no_regressions reliable across multi-line stack traces.
  • Watch out for an IndexError edge case in run_single_query when str(exc) is empty.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

Comment thread sdks/python/apache_beam/testing/benchmarks/tpcds/tpcds_launcher.py
Comment thread sdks/python/apache_beam/testing/benchmarks/tpcds/tpcds_queries.py Outdated
@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.92%. Comparing base (a8d6afd) to head (5345eea).
⚠️ Report is 58 commits behind head on master.

Files with missing lines Patch % Lines
...he_beam/testing/benchmarks/tpcds/tpcds_launcher.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #40741      +/-   ##
==========================================
- Coverage   80.04%   79.92%   -0.13%     
==========================================
  Files         490      493       +3     
  Lines       82916    83408     +492     
==========================================
+ Hits        66373    66661     +288     
- Misses      16543    16747     +204     
Flag Coverage Δ
python 79.92% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @chamikaramj for label java.
Backup reviewer: kennknowles (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Abacn

Abacn commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@kennknowles

Copy link
Copy Markdown
Member

The local environment test is failing in a way I have seen before but I don't remember. I think it is printing the Java version then exiting, but not sure why it doesn't give a full error message. I've seen this across many PRs and I assume it is an environmental issue.

@Abacn
Abacn merged commit 61a94bd into apache:master Oct 23, 2026
110 of 114 checks passed
@Abacn
Abacn deleted the fix-tpcds-py branch October 24, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants