Skip to content

Update transformers bounds and tests - #40745

Merged
jrmccluskey merged 3 commits into
apache:masterfrom
jrmccluskey:transformerBump
Oct 23, 2026
Merged

jrmccluskey merged 3 commits into
apache:masterfrom
jrmccluskey:transformerBump

Conversation

@jrmccluskey

Copy link
Copy Markdown
Contributor

Fix transformers bounds, update to new test environments.

@github-actions github-actions Bot added python size/s S: 10-49 lines changed labels Oct 23, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates the transformers and torch version bounds in the transformers extra, updates the corresponding tox.ini and Gradle test environments to test against transformers 4.41, 4.57, and 5.20 (latest), and removes TFAutoModel references in huggingface_inference_test.py for compatibility with transformers 5.x (which dropped TensorFlow support).

🔍 General Feedback

  • The changes across setup.py, tox.ini, build.gradle, and huggingface_inference_test.py are clean, well-documented with inline comments explaining dependency constraints, and properly synchronized.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.93%. Comparing base (a8d6afd) to head (6af8ec4).
⚠️ Report is 60 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #40745      +/-   ##
==========================================
- Coverage   80.04%   79.93%   -0.12%     
==========================================
  Files         490      493       +3     
  Lines       82916    83402     +486     
==========================================
+ Hits        66373    66670     +297     
- Misses      16543    16732     +189     
Flag Coverage Δ
python 79.93% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jrmccluskey

Copy link
Copy Markdown
Contributor Author

CC: @aIbrahiim

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @tvalentyn for label python.
Backup reviewer: claudevdm (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey
jrmccluskey merged commit 5d0fdfb into apache:master Oct 23, 2026
93 of 94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants