Skip to content

Update tensorflow dependencies - #40752

Open
jrmccluskey wants to merge 2 commits into
apache:masterfrom
jrmccluskey:tfBump
Open

jrmccluskey wants to merge 2 commits into
apache:masterfrom
jrmccluskey:tfBump

Conversation

@jrmccluskey

Copy link
Copy Markdown
Contributor

Clean up tensorflow versions, add context for current restrictions. This should finish fixing the dependency post-commit and get most of the ML tests functioning again.

@github-actions github-actions Bot added python size/m M: 50-249 lines changed labels Oct 23, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates the TensorFlow, TensorFlow Hub, and TensorFlow Transform dependency ranges and corresponding Tox/Gradle test environments to align with modern releases (tensorflow>=2.16.0,<2.22, tensorflow-hub>=0.16.1,<0.17, tensorflow-transform>=1.21.0,<1.22.0). It also resolves packaging compatibility issues with setuptools<82 and protobuf, and fixes an exception assertion in tensorflow_hub_test.py for portable runners.

🔍 General Feedback

  • The dependency constraints, comments explaining transitive version requirements (such as protobuf, tf-keras, and setuptools<82), and synchronization between setup.py, tox.ini, and Gradle tasks are clear and well-structured.
  • One minor cleanup opportunity in sdks/python/test-suites/tox/py312/build.gradle: def posargs = project.findProperty("posargs") ?: "" on line 25 is now unused after removing testPy312tensorflow-216 (similar to py313/build.gradle).

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.93%. Comparing base (a8d6afd) to head (0f85d5b).
⚠️ Report is 74 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #40752      +/-   ##
==========================================
- Coverage   80.04%   79.93%   -0.12%     
==========================================
  Files         490      493       +3     
  Lines       82916    83431     +515     
==========================================
+ Hits        66373    66688     +315     
- Misses      16543    16743     +200     
Flag Coverage Δ
python 79.93% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @shunping for label python.
Backup reviewer: damccorm (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@shunping shunping left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Segmentation fault in YAML test seems to be a real problem. I suspect there are some incompatible deps here. Could you look into that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants