Repository navigation
Update tensorflow dependencies - #40752
jrmccluskey wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
📋 Review Summary
This PR updates the TensorFlow, TensorFlow Hub, and TensorFlow Transform dependency ranges and corresponding Tox/Gradle test environments to align with modern releases (tensorflow>=2.16.0,<2.22, tensorflow-hub>=0.16.1,<0.17, tensorflow-transform>=1.21.0,<1.22.0). It also resolves packaging compatibility issues with setuptools<82 and protobuf, and fixes an exception assertion in tensorflow_hub_test.py for portable runners.
🔍 General Feedback
- The dependency constraints, comments explaining transitive version requirements (such as
protobuf,tf-keras, andsetuptools<82), and synchronization betweensetup.py,tox.ini, and Gradle tasks are clear and well-structured. - One minor cleanup opportunity in
sdks/python/test-suites/tox/py312/build.gradle:def posargs = project.findProperty("posargs") ?: ""on line 25 is now unused after removingtestPy312tensorflow-216(similar topy313/build.gradle).
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40752 +/- ##
==========================================
- Coverage 80.04% 79.93% -0.12%
==========================================
Files 490 493 +3
Lines 82916 83431 +515
==========================================
+ Hits 66373 66688 +315
- Misses 16543 16743 +200
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Clean up tensorflow versions, add context for current restrictions. This should finish fixing the dependency post-commit and get most of the ML tests functioning again.