Skip to content

Rename TestRecord - #40758

Open
aIbrahiim wants to merge 1 commit into
apache:masterfrom
aIbrahiim:rename-test-record-2
Open

aIbrahiim wants to merge 1 commit into
apache:masterfrom
aIbrahiim:rename-test-record-2

Conversation

@aIbrahiim

Copy link
Copy Markdown
Contributor

Fixes: #39472

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR renames nested Record helper classes in several unit tests (CloningBundleFactoryTest, CloudObjectsTest, and CreateTest) to TestRecord to resolve ErrorProne JavaLangClash warnings against java.lang.Record on Java 17+. The renaming is accurate and complete across all three test files, though a few modified lines now exceed the 100-character limit enforced by Spotless (google-java-format).

🔍 General Feedback

  • Please run ./gradlew spotlessApply (or wrap the lines flagged below) so the beam_PreCommit_Spotless check passes.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

Comment thread sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/CreateTest.java Outdated
@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@aIbrahiim
aIbrahiim force-pushed the rename-test-record-2 branch from 1f8d1c2 to 2213e54 Compare October 24, 2026 09:35
@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @ahmedabu98 for label java.
Backup reviewer: damccorm (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@codecov

codecov Bot commented Oct 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (a8d6afd) to head (2213e54).
⚠️ Report is 70 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #40758       +/-   ##
===========================================
- Coverage   80.04%        0   -80.05%     
===========================================
  Files         490        0      -490     
  Lines       82916        0    -82916     
===========================================
- Hits        66373        0    -66373     
+ Misses      16543        0    -16543     
Flag Coverage Δ
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PreCommit SQL Java17 job is flaky

1 participant