Skip to content

[Cherrypick] Update ONNX extras (#40821) - #40884

Merged
jrmccluskey merged 1 commit into
apache:release-2.78from
jrmccluskey:onnxCherrypick
Oct 29, 2026
Merged

jrmccluskey merged 1 commit into
apache:release-2.78from
jrmccluskey:onnxCherrypick

Conversation

@jrmccluskey

Copy link
Copy Markdown
Contributor
  • Update ONNX extras

  • Trigger postcommits

  • Fix py311-ml onnx bounds

  • add onnxscript to tox environment

  • Add onnxscript to ml_base

* Update ONNX extras

* Trigger postcommits

* Fix py311-ml onnx bounds

* add onnxscript to tox environment

* Add onnxscript to ml_base
@github-actions github-actions Bot added python size/m M: 50-249 lines changed labels Oct 29, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR cleanly cherry-picks #40821 into release-2.78, modernizing the ONNX optional dependencies in setup.py and re-enabling the ONNX inference unit test suite across tox.ini and Gradle.

🔍 General Feedback

  • The cherry-pick matches the original commit in #40821 with no merge discrepancies.
  • Keras 3 compatibility adjustments, PyTorch opset updates, and tox dependency bounds are well-structured and properly aligned.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.81%. Comparing base (3b59922) to head (cc9bbe2).
⚠️ Report is 1 commits behind head on release-2.78.

Additional details and impacted files
@@                Coverage Diff                @@
##           release-2.78   #40884       +/-   ##
=================================================
+ Coverage              0   79.81%   +79.81%     
=================================================
  Files                 0      494      +494     
  Lines                 0    83573    +83573     
=================================================
+ Hits                  0    66707    +66707     
- Misses                0    16866    +16866     
Flag Coverage Δ
python 79.81% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label python.
Backup reviewer: tvalentyn (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey
jrmccluskey merged commit a81f77b into apache:release-2.78 Oct 29, 2026
91 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants