[CALCITE-6792] RelJsonReader failed to read RelJsonWriter output if 'NaN' or 'Infinity' approximate numerics are present - #5220
Open
1fanwang wants to merge 3 commits into
Conversation
…NaN' or 'Infinity' approximate numerics are present RelJson emitted IEEE 754 special values as bare tokens, which are invalid JSON and cannot be parsed through the readers BigDecimal mode. Encode them as typed strings so plans containing approximate literals round-trip. Signed-off-by: 1fanwang <1fannnw@gmail.com>
Member
|
please correct your pr title which should be consistent with jira. |
1fanwang
changed the title
mihaibudiu
reviewed
Aug 25, 2026
mihaibudiu
left a comment
mihaibudiu
left a comment
Contributor
There was a problem hiding this comment.
Can you add some round-trip tests, where the plan is serialized and deserialized and compared with the original?
| value instanceof Enum | ||
| ? RelEnumTypes.fromEnum((Enum) value) | ||
| : toJson(value)); | ||
| if (value instanceof Enum) { |
Contributor
There was a problem hiding this comment.
What case is this branch covering?
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Signed-off-by: 1fanwang <1fannnw@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-6792
Changes Proposed
A plan containing NaN or infinity cannot make a RelJson round trip. The writer emits those values as bare tokens, and the reader fails with:
Non-finite approximate literals are now written as JSON strings. When the declared type is approximate, the reader converts those strings back to doubles. Finite numbers remain numeric, and a character literal containing "Infinity" remains a string.
Testing