Repository navigation
Conversation
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
gnodet-bot
left a comment
There was a problem hiding this comment.
The mechanical version bump (4.23.0-SNAPSHOT → 4.24.0-SNAPSHOT) looks correct across all files. However, the find-and-replace only targeted -SNAPSHOT occurrences — four comment/documentation examples still pair 4.24.0-SNAPSHOT with 4.23.0 as the stripped result, which is now incorrect.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
| - Read the `<version>` from the root `pom.xml` on the PR's **target branch** (e.g., `main`, | ||
| `camel-4.18.x`). | ||
| - Strip the `-SNAPSHOT` suffix to get the milestone name (e.g., `4.23.0-SNAPSHOT` → `4.23.0`). | ||
| - Strip the `-SNAPSHOT` suffix to get the milestone name (e.g., `4.24.0-SNAPSHOT` → `4.23.0`). |
There was a problem hiding this comment.
4.24.0-SNAPSHOT but the derived version in this example was left as 4.23.0. AI agents reading these guidelines after the merge will apply the wrong milestone.
| - Strip the `-SNAPSHOT` suffix to get the milestone name (e.g., `4.24.0-SNAPSHOT` → `4.23.0`). | |
| - Strip the `-SNAPSHOT` suffix to get the milestone name (e.g., `4.24.0-SNAPSHOT` → `4.24.0`). |
| - **Scope-too-large redirect:** create a Jira issue directly | ||
| - **Merge procedure:** | ||
| 1. Derive milestone from target branch: read `<version>` from root `pom.xml` on the target branch and strip `-SNAPSHOT` (e.g., `4.23.0-SNAPSHOT` → `4.23.0`) | ||
| 1. Derive milestone from target branch: read `<version>` from root `pom.xml` on the target branch and strip `-SNAPSHOT` (e.g., `4.24.0-SNAPSHOT` → `4.23.0`) |
There was a problem hiding this comment.
4.24.0-SNAPSHOT paired with 4.23.0. Should be 4.24.0.
| 1. Derive milestone from target branch: read `<version>` from root `pom.xml` on the target branch and strip `-SNAPSHOT` (e.g., `4.24.0-SNAPSHOT` → `4.23.0`) | |
| 1. Derive milestone from target branch: read `<version>` from root `pom.xml` on the target branch and strip `-SNAPSHOT` (e.g., `4.24.0-SNAPSHOT` → `4.24.0`) |
| @@ -84,7 +84,7 @@ public CamelCatalog loadCatalog(String runtime, String camelVersion, String plat | |||
| boolean hasVersion = camelVersion != null && !camelVersion.isBlank() && !camelVersion.isEmpty() | |||
| && Character.isDigit(camelVersion.trim().charAt(0)); | |||
| if (hasVersion && sameAsDefault(camelVersion)) { | |||
| // the version in use (4.23.0 for a 4.23.0-SNAPSHOT build): nothing to download | |||
| // the version in use (4.23.0 for a 4.24.0-SNAPSHOT build): nothing to download | |||
There was a problem hiding this comment.
💡 Stale comment: The comment says 4.23.0 for a 4.24.0-SNAPSHOT build — the stripped version should now be 4.24.0.
| // the version in use (4.23.0 for a 4.24.0-SNAPSHOT build): nothing to download | |
| // the version in use (4.24.0 for a 4.24.0-SNAPSHOT build): nothing to download |
| @@ -59,7 +59,7 @@ void validatesValidMainProperty() { | |||
|
|
|||
| @Test | |||
| void theRunningVersionWithoutSnapshotIsTheDefaultCatalog() { | |||
| // an assistant that reads "4.23.0-SNAPSHOT" from the server asks for 4.23.0, which is not on Maven Central | |||
| // an assistant that reads "4.24.0-SNAPSHOT" from the server asks for 4.23.0, which is not on Maven Central | |||
There was a problem hiding this comment.
💡 Stale comment: Says asks for 4.23.0 — after the bump, the stripped SNAPSHOT version is 4.24.0.
| // an assistant that reads "4.24.0-SNAPSHOT" from the server asks for 4.23.0, which is not on Maven Central | |
| // an assistant that reads "4.24.0-SNAPSHOT" from the server asks for 4.24.0, which is not on Maven Central |
Description
Since 4.23 is released, bump version to 4.24.0-SNAPSHOT on the
mainbranch.