Repository navigation
CAMEL-24812: ci - do not include modules located under src/ in the in… - #27947
Conversation
…cremental build pom.xml files under a module's src/ directory (src/main/resources archetype templates, src/it fixtures) are not reactor modules and must not be selected with -pl. Walk up to the owning module in findProjectRoot, skip files nested in archetype-resources, and filter such paths out of the Scalpel report. Remove the camel-salesforce-maven-plugin exclusion and manual IT mapping which are no longer needed. Co-authored-by: IBM Bob 2.2.1 Signed-off-by: Aurélien Pupier <apupier@ibm.com>
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
ℹ️ CI did not run targeted module tests. |
|
testing with a specific Build https://github.com/apache/camel/actions/runs/38905528199/job/116988017568 it seems to go further |
davsclaus
left a comment
There was a problem hiding this comment.
Thanks @apupier, this is the proper fix that the CAMEL-24812 workaround (be48e9b) asked for: a change under a module's src/ now resolves to the owning module, so the camel-salesforce-maven-plugin exclusion is no longer needed. findProjectRoot keeps walking up past any */src/* path, files nested in archetype-resources are skipped, and the Scalpel report gets the same filter.
One question before merging: be48e9b added the manual-it-mapping.txt entry together with the exclusion, so that a change to the plugin still ran its plugin-itest invoker ITs. With the entry removed, the plugin is built and tested again, but plugin-itest is a profile that the incremental build does not enable, so the src/it projects (customized-types, simple-it) no longer run on a plugin change. Was dropping that coverage intended? If not, the mapping line can stay, since it no longer conflicts with the module being in the reactor.
The PR description is still the empty template. The commit message explains the change well, so copying it in would help reviewers.
Approving; the question above is not blocking.
Claude Code on behalf of Claus Ibsen
…cremental build
pom.xml files under a module's src/ directory (src/main/resources archetype templates, src/it fixtures) are not reactor modules and must not be selected with -pl. Walk up to the owning module in findProjectRoot, skip files nested in archetype-resources, and filter such paths out of the Scalpel report.
Remove the camel-salesforce-maven-plugin exclusion and manual IT mapping which are no longer needed.
Co-authored-by: IBM Bob 2.2.1
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.AI-assisted contributions
Co-authored-bytrailers) and the PR description identifies the AI tool used.