Skip to content

CAMEL-24812: ci - do not include modules located under src/ in the in… - #27947

Merged
davsclaus merged 1 commit into
mainfrom
fixGitHubActionsScriptToNotIncludeModulesInsideSrcMainResourcesOrSrcIT
Oct 16, 2026
Merged

davsclaus merged 1 commit into
mainfrom
fixGitHubActionsScriptToNotIncludeModulesInsideSrcMainResourcesOrSrcIT

Conversation

@apupier

@apupier apupier commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

…cremental build

pom.xml files under a module's src/ directory (src/main/resources archetype templates, src/it fixtures) are not reactor modules and must not be selected with -pl. Walk up to the owning module in findProjectRoot, skip files nested in archetype-resources, and filter such paths out of the Scalpel report.

Remove the camel-salesforce-maven-plugin exclusion and manual IT mapping which are no longer needed.

Co-authored-by: IBM Bob 2.2.1

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

AI-assisted contributions

  • If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., Co-authored-by trailers) and the PR description identifies the AI tool used.

…cremental build

pom.xml files under a module's src/ directory (src/main/resources archetype
templates, src/it fixtures) are not reactor modules and must not be selected
with -pl. Walk up to the owning module in findProjectRoot, skip files nested in
archetype-resources, and filter such paths out of the Scalpel report.

Remove the camel-salesforce-maven-plugin exclusion and manual IT mapping which
are no longer needed.

Co-authored-by: IBM Bob 2.2.1
Signed-off-by: Aurélien Pupier <apupier@ibm.com>
@github-actions

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions

Copy link
Copy Markdown
Contributor

ℹ️ CI did not run targeted module tests.


⚙️ View full build and test results

@apupier

apupier commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

testing with a specific Build https://github.com/apache/camel/actions/runs/38905528199/job/116988017568 it seems to go further

@apupier
apupier marked this pull request as ready for review October 16, 2026 13:36
@apupier
apupier requested review from davsclaus and gnodet October 16, 2026 13:47

@davsclaus davsclaus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apupier, this is the proper fix that the CAMEL-24812 workaround (be48e9b) asked for: a change under a module's src/ now resolves to the owning module, so the camel-salesforce-maven-plugin exclusion is no longer needed. findProjectRoot keeps walking up past any */src/* path, files nested in archetype-resources are skipped, and the Scalpel report gets the same filter.

One question before merging: be48e9b added the manual-it-mapping.txt entry together with the exclusion, so that a change to the plugin still ran its plugin-itest invoker ITs. With the entry removed, the plugin is built and tested again, but plugin-itest is a profile that the incremental build does not enable, so the src/it projects (customized-types, simple-it) no longer run on a plugin change. Was dropping that coverage intended? If not, the mapping line can stay, since it no longer conflicts with the module being in the reactor.

The PR description is still the empty template. The commit message explains the change well, so copying it in would help reviewers.

Approving; the question above is not blocking.

Claude Code on behalf of Claus Ibsen

@davsclaus davsclaus added this to the 4.24.0 milestone Oct 16, 2026
@davsclaus davsclaus added the task label Oct 16, 2026
@davsclaus
davsclaus merged commit b9ce3e7 into main Oct 16, 2026
5 checks passed
@davsclaus
davsclaus deleted the fixGitHubActionsScriptToNotIncludeModulesInsideSrcMainResourcesOrSrcIT branch October 16, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants