CAMEL-24961: camel-yaml-dsl-validator - the body walks read the body types of the catalog instead of their own tables

docs/user-manual/modules/ROOT/pages/camel-catalog.adoc

@@ -191,6 +191,10 @@ options a side names exist, that `unchanged` is only on the body after a step an
 The values are read from the code that sets the body, and checked against the body types the message history records
 when the routes run.
 
+The YAML validator of the Camel CLI follows the body through the steps of a route with the body types, and reports a
+step that cannot work on it, such as a Map that a `to: file` cannot write (see
+xref:camel-jbang-validation.adoc#_what_a_running_integration_saw[Camel CLI validation]).
+
 === Documentation in the Catalog
 
 The catalog includes the AsciiDoc documentation pages from all modules. This makes the full

docs/user-manual/modules/ROOT/pages/camel-jbang-validation.adoc

@@ -75,8 +75,12 @@ A part of a Java route the parser cannot work out (a value computed at runtime)
 
 The YAML validator follows the message body through the steps of each route, and reports a step that cannot work on
 it: a field read such as `+${body.qty}+` on text that was never unmarshalled, or a Map that a `to: file` cannot write.
-Where the file does not tell what the body is, such as after a `platform-http` or `kafka` consumer, or after a call
-with `to: http`, it says nothing.
+What a component or a data format does with the body comes from the
+xref:camel-catalog.adoc#_body_types_in_the_catalog[body types in the catalog]: the file consumer gives the file it
+read, the `http` producer leaves the response as bytes or a stream, and `unmarshal: json` makes a Map or a List.
+Where they do not tell what the body is, the validator says nothing: after a `platform-http` consumer the body
+depends on the request, and the deserializer of a `kafka` consumer can be set on the component, which the route file
+does not show.
 
 When an integration runs the routes of the file with the message history on, such as with `camel run --dev`, the
 validator fills these gaps with what the integration saw at the endpoints of its routes: the body each consumer gave,

dsl/camel-yaml-dsl/camel-yaml-dsl-validator/src/main/java/org/apache/camel/dsl/yaml/validator/BodyTypeFlow.java

@@ -29,6 +29,7 @@
 
 import static org.apache.camel.dsl.yaml.validator.RouteGraph.Route;
 import static org.apache.camel.dsl.yaml.validator.RouteGraph.endpointOf;
+import static org.apache.camel.dsl.yaml.validator.RouteGraph.from;
 import static org.apache.camel.dsl.yaml.validator.RouteGraph.normalize;
 import static org.apache.camel.dsl.yaml.validator.RouteGraph.routes;
 import static org.apache.camel.dsl.yaml.validator.RouteGraph.scheme;
@@ -63,21 +64,15 @@ final class BodyTypeFlow {
     /** The REST verbs that carry no body, so a route they send to starts with none. */
     private static final Set<String> VERBS_WITHOUT_BODY = Set.of("get", "delete", "head");
 
-    /** The consumers that produce no body of their own, so the message reaching the route has none. */
-    private static final Set<String> NO_BODY_CONSUMER = Set.of("timer", "quartz", "scheduler", "cron");
-
     private BodyTypeFlow() {
     }
 
-    static void check(JsonNode target, NodePath path, List<Error> errors) {
-        check(target, path, errors, Set.of());
-    }
-
     /**
-     * @param known the endpoints the caller knows deliver no body, such as {@code direct:getStock} for the GET
-     *              operation of an OpenAPI specification the route binds to (CAMEL-24844 phase B)
+     * @param known     the endpoints the caller knows deliver no body, such as {@code direct:getStock} for the GET
+     *                  operation of an OpenAPI specification the route binds to (CAMEL-24844 phase B)
+     * @param bodyTypes the body types of the catalog, which say the consumers that give no body (timer, cron)
      */
-    static void check(JsonNode target, NodePath path, List<Error> errors, Set<String> known) {
+    static void check(JsonNode target, NodePath path, List<Error> errors, Set<String> known, CatalogBodyTypes bodyTypes) {
         List<Route> routes = routes(target);
         if (routes.isEmpty()) {
             return;
@@ -106,7 +101,7 @@ static void check(JsonNode target, NodePath path, List<Error> errors, Set<String
             if (reader == null) {
                 continue;
             }
-            if (!certainlyWithoutABody(r, callers, restless, new HashSet<>())) {
+            if (!certainlyWithoutABody(r, callers, restless, new HashSet<>(), bodyTypes)) {
                 continue;
             }
             errors.add(Error.builder()
@@ -131,15 +126,17 @@ static void check(JsonNode target, NodePath path, List<Error> errors, Set<String
      */
     private static boolean certainlyWithoutABody(
             Route route, Map<Route, List<Route>> callers, Set<String> restless,
-            Set<Route> seen) {
+            Set<Route> seen, CatalogBodyTypes bodyTypes) {
         if (!seen.add(route)) {
             return false; // a cycle: say nothing
         }
         String scheme = scheme(route.fromUri());
         if (scheme == null) {
             return false;
         }
-        if (NO_BODY_CONSUMER.contains(scheme)) {
+        // a consumer that produces no body of its own, as the catalog says: timer, cron, scheduler, quartz
+        CatalogBodyTypes.Answer out = bodyTypes.consumerOut(route.fromUri(), from(route.node()));
+        if (out != null && out.none()) {
             return true;
         }
         if (!"direct".equals(scheme) && !"seda".equals(scheme) && !"direct-vm".equals(scheme)) {
@@ -155,7 +152,7 @@ private static boolean certainlyWithoutABody(
             if (setsTheBodyBeforeSendingTo(caller, route)) {
                 return false;
             }
-            if (!certainlyWithoutABody(caller, callers, restless, seen)) {
+            if (!certainlyWithoutABody(caller, callers, restless, seen, bodyTypes)) {
                 return false;
             }
         }