CAMEL-25875: camel-milo - a sessionTimeout configured on the component reaches its endpoints

components/camel-milo/src/main/java/org/apache/camel/component/milo/client/MiloClientConfiguration.java

@@ -144,6 +144,7 @@ public MiloClientConfiguration(final MiloClientConfiguration other) {
         this.applicationUri = other.applicationUri;
         this.productUri = other.productUri;
         this.requestTimeout = other.requestTimeout;
+        this.sessionTimeout = other.sessionTimeout;
         this.reconnectTimeout = other.reconnectTimeout;
         this.channelLifetime = other.channelLifetime;
         this.sessionName = other.sessionName;

components/camel-milo/src/test/java/org/apache/camel/component/milo/SessionTimeoutConfigurationTest.java

@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.component.milo;
+
+import org.apache.camel.component.milo.browse.MiloBrowseComponent;
+import org.apache.camel.component.milo.browse.MiloBrowseEndpoint;
+import org.apache.camel.component.milo.client.MiloClientComponent;
+import org.apache.camel.component.milo.client.MiloClientEndpoint;
+import org.apache.camel.test.junit6.CamelTestSupport;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+/**
+ * A session timeout configured on the component reaches its endpoints.
+ */
+public class SessionTimeoutConfigurationTest extends CamelTestSupport {
+
+    private static final String SERVER = "opc.tcp://localhost:4840";
+
+    @Test
+    void clientComponentSetsTheDefaultSessionTimeoutOfItsEndpoints() {
+        context.getComponent("milo-client", MiloClientComponent.class).getConfiguration().setSessionTimeout(30_000L);
+
+        assertEquals(30_000L,
+                context.getEndpoint("milo-client:" + SERVER, MiloClientEndpoint.class).getConfiguration()
+                        .getSessionTimeout());
+        assertEquals(45_000L,
+                context.getEndpoint("milo-client:" + SERVER + "?sessionTimeout=45000", MiloClientEndpoint.class)
+                        .getConfiguration().getSessionTimeout());
+    }
+
+    @Test
+    void browseComponentSetsTheDefaultSessionTimeoutOfItsEndpoints() {
+        context.getComponent("milo-browse", MiloBrowseComponent.class).getConfiguration().setSessionTimeout(30_000L);
+
+        assertEquals(30_000L,
+                context.getEndpoint("milo-browse:" + SERVER, MiloBrowseEndpoint.class).getConfiguration()
+                        .getSessionTimeout());
+        assertEquals(45_000L,
+                context.getEndpoint("milo-browse:" + SERVER + "?sessionTimeout=45000", MiloBrowseEndpoint.class)
+                        .getConfiguration().getSessionTimeout());
+    }
+}

docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_24.adoc

@@ -2260,6 +2260,12 @@ and the delay between two connection attempts stayed 10 seconds. It now sets tha
 delay, and a value of 0 or less is rejected. To set the request timeout, use the `requestTimeout` option instead
 (for example `camel.component.milo-client.requestTimeout`, or `getConfiguration().setRequestTimeout(...)` in Java).
 
+=== camel-milo - the sessionTimeout of the components reaches their endpoints
+
+A `sessionTimeout` configured on the `milo-client` or `milo-browse` component (for example
+`camel.component.milo-client.sessionTimeout`) did not reach its endpoints, so their sessions used the default of Milo,
+120000 milliseconds. The endpoints now use it, unless they set `sessionTimeout` themselves.
+
 === camel-infinispan - the key option of the producer takes precedence over the key header
 
 The `infinispan` and `infinispan-embedded` producers now use the `key` option of the endpoint when it is set, and use the