Repository navigation
[backport camel-4.22.x] CAMEL-25875: camel-milo - a sessionTimeout configured on the component reaches its endpoints - #28316
Conversation
gnodet-bot
left a comment
There was a problem hiding this comment.
LGTM. Clean backport — single-line fix restoring the missing sessionTimeout copy in the constructor, with tests that confirm the value propagates from component to endpoint (and that an endpoint-level override still wins). No issues found.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
…nfigured on the component reaches its endpoints
a7a5186 to
a0c885f
Compare
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 9 tested, 29 compile-only — current: 9 all testedMaveniverse Scalpel detected 38 affected modules (current approach: 9).
|
davsclaus
left a comment
There was a problem hiding this comment.
TL;DR
The fix and the test are the same as #28252, and CI is green.
Blockers: None
Other findings: 1 optional point and 1 question.
- Optional: the upgrade-guide note from #28252 (4.24 guide) is not carried over. The fix ships in 4.22.3, and main's "Upgrading from 4.22.2 to 4.22.3" section already has similar notes, for example
camel-pubnub - the producer uses its configured channel. If you want the same here, the 4.24 text can go under "Upgrading from 4.22.2 to 4.22.3" on this branch and on main. - Question: camel-4.18.x has the same missing line in the copy constructor of
MiloClientConfiguration. Is a 4.18.x backport planned? There the test would needorg.apache.camel.test.junit5.CamelTestSupport, because camel-milo on 4.18.x uses the junit5 test support.
The only difference in the code is context: main also copies reconnectTimeout in the same constructor (CAMEL-25873, main only), and camel-4.22.x does not have that field. SessionTimeoutConfigurationTest ran in CI: 2 tests, no failures.
Reviewed with Claude Code on behalf of @davsclaus. This review was generated by an AI agent and may contain inaccuracies; please verify all suggestions before applying.
Backport of #28252
Cherry-pick of aaf0369 to camel-4.22.x.
Conflicts resolved automatically by backport bot agent.