Repository navigation
[backport camel-4.22.x] CAMEL-25994: camel-undertow - WebSocket: keep the OAuth validation of a connection per endpoint, like the other security checks - #28337
Conversation
… the OAuth validation of a connection per endpoint, like the other security checks
davsclaus
left a comment
There was a problem hiding this comment.
TL;DR
Comment: the OAuth hunks match #28297, but this backport depends on CAMEL-25917 (#28237), which is not on camel-4.22.x yet.
Blockers
UndertowWsOAuthProfileConsumerChangeTest.java:72waits for the first channel to be closed after the consumer changes. On main that close comes fromclosePeersThatNoLongerPassChecks(), whichsetConsumercalls (added by #28237). On camel-4.22.xsetConsumer(CamelWebSocketHandler.java:402) closes nothing, so the test is expected to time out after 10 s.- The conflict resolution added a
consumerfield toHandshakeResult(CamelWebSocketHandler.java:685) that nothing reads on this branch. On main its reader also comes from #28237.
Suggested fix: backport #28237 to camel-4.22.x first, then cherry-pick #28297 again.
Reviewed with Claude Code on behalf of davsclaus. This review was generated by an AI agent and may contain inaccuracies; please verify all suggestions before applying.
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 38 tested, 29 compile-only — current: 38 all testedMaveniverse Scalpel detected 67 affected modules (current approach: 38).
|
Backport of #28297
Cherry-pick of f4ea671 to camel-4.22.x.
Conflicts resolved automatically by backport bot agent.