Repository navigation
Conversation
…mestream, s3-vectors, security-hub and cloudtrail CAMEL-26072 aws2-polly: the textType and outputFormat headers are read; next token header; lexicon names trimmed CAMEL-26073 aws2-translate: each language from its option or header; Croatian is hr CAMEL-26074 aws2-textract: feature types as Strings; the start operations set the job id header CAMEL-26077 aws2-timestream: describeScheduledQuery sends the ARN; clear errors for the operation and client type CAMEL-26078 aws-cloudtrail: application/json for the CloudEvent data type; events without data or time CAMEL-26079 aws2-polly, textract, sns, s3: trace logs and checks of an AWS error without details CAMEL-26092 aws2-s3-vectors: no output bucket/index headers, keys from the body, data/metadata/distance, metadata filter CAMEL-26094 aws-security-hub: headers of another type fail, findings as any collection, failed imports fail Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet-bot
reviewed
Oct 23, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
Contributor
There was a problem hiding this comment.
Thorough, well-tested fix for seven AWS components. Every behavior change has a unit test, null-safety improvements are correct, s3-vectors deprecations are appropriate, and the upgrade guide is comprehensive. LGTM.
Pre-fix test validation (sampled):
- ✅ CAMEL-26074 (textract
ClassCastException):Textract2ProducerTest.analyzeDocumentFeatureTypesFromListOfStrings()sendsList.of("tables", "Signatures")through the newgetFeatureTypes()method which parses Strings → FeatureType. Before the fix, this list would have been cast directly toList<FeatureType>, causing aClassCastException. The test asserts the correct FeatureTypes are received by the mock. - ✅ CAMEL-26073 (translate: one option sends no other language):
Translate2ProducerTest.sourceLanguageOptionAndTargetLanguageHeader()sets onlysourceLanguageas an option andtargetLanguageas a header. The old code only read both from options or both from headers — not one from each. The test asserts both languages arrive at the mock. - ✅ CAMEL-26092 (s3-vectors bucket/index headers redirect):
AWS2S3VectorsProducerRequestTest.putVectorsDoesNotSetBucketAndIndexHeaders()verifies the headers are no longer set;getVectorsTakesTheKeysFromTheBodyBeforeTheHeader()confirms body-first key resolution. - ✅ CAMEL-26079 (NPE on AWS error without details):
AWS2S3MissingBucketTestmocks anAwsServiceExceptionwithstatusCode(404)but noawsErrorDetails(), and verifies the bucket creation proceeds. Before the fix,ase.awsErrorDetails().sdkHttpResponse().statusCode()would NPE.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 17 of 707 tested, 23 compile-only — current: 17 all testedMaveniverse Scalpel detected 17 affected modules (current approach: 17). Skip-tests mode would test 17 modules (13 direct + 8 downstream), skip tests for 23 (generated code, meta-modules) Modules Scalpel would test (17)
Modules with tests skipped (23)
All tested modules (44 modules, 7m 28s total)Total reactor time: 7m 28s
Top 20 slowest modules:
|
Main's new body type text is updated where this PR changes the behavior it describes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
davsclaus
added a commit
that referenced
this pull request
Oct 24, 2026
…mestream, s3-vectors, security-hub and cloudtrail (#28376) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Contributor
Author
|
Merged to main as 70be315 (squashed together with the other body type bug batches, tested together locally). Claude Code on behalf of davsclaus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Code on behalf of davsclaus
Bug fixes for seven AWS components, found while adding the catalog body types (CAMEL-24961). One commit; every behaviour fix has a unit test that failed before it.
textTypeandoutputFormathave no default, so their headers are read (SSML was spoken as text); TEXT and MP3 when neither is set; newCamelAwsPollyNextTokenheader (in and out) for the list operations; lexicon names trimmed; docshr(wascr, Cree); docsCamelAwsTextractFeatureTypestakes Strings (was aClassCastException); the start operations setCamelAwsTextractJobId, so a get step that follows works; docs on which S3 location and body are usedapplication/json; an event without data or time no longer fails every poll; docsNullPointerException(aws-config and rekognition are in #28353, which changes the same files)CamelAwsS3VectorsDistanceheader; the threshold and score, which never worked, are deprecated; metadata values of any JSON scalar type; option enums as in the SDKBehaviour changes are in the 4.24 upgrade guide; the main ones: the polly headers are now used, s3-vectors no longer sets the bucket and index headers and get/delete read the keys from the body first, security-hub batchImportFindings fails on failed findings, translate's
CROATIANishr.Not in this PR: CAMEL-26069 and CAMEL-26071 (bedrock) wait for #28353.
Catalog JSON and docs copied, endpoint and component DSLs regenerated. Main only.
The stacked body-type PRs #28340, #28343, #28275 and #28251 touch the same endpoints and generated JSON; whichever merges second regenerates.
🤖 Generated with Claude Code