Repository navigation
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
🔁 1 test passed only after a retry on JDK 21 (1 retried attempt) Recovered flaky tests on JDK 21 (1)
🔬 Scalpel shadow comparison — Scalpel: 22 of 707 tested, 26 compile-only — current: 22 all testedMaveniverse Scalpel detected 22 affected modules (current approach: 22). Skip-tests mode would test 22 modules (13 direct + 10 downstream), skip tests for 26 (generated code, meta-modules) Modules Scalpel would test (22)
Modules with tests skipped (26)
All tested modules (49 modules, 8m 56s total)Total reactor time: 8m 56s
Top 20 slowest modules:
|
…, asterisk, grpc, thrift, avro, cometd, cometds, quickfix, jgroups and jgroups-raft Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
davsclaus
force-pushed
the
feature/CAMEL-24961-body-types-network-rpc
branch
from
October 24, 2026 15:32
489811a to
ea47364
Compare
davsclaus
added a commit
that referenced
this pull request
Oct 24, 2026
…ometd, quickfix, jgroups and five more network components (#28413) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Contributor
Author
|
Merged to main as ad0525e (squashed with the other CAMEL-24961 body type groups, tested together locally). Claude Code on behalf of davsclaus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Code on behalf of davsclaus
This group adds the catalog body types (CAMEL-24961) for thirteen network and RPC components: mina, mina-sftp, mllp, lumberjack, asterisk, grpc, thrift, avro, cometd, cometds, quickfix, jgroups and jgroups-raft. Each change is an
@BodyTypesannotation on the Endpoint, plus the JSON it generates and the catalog copy. Three doc pages had their body text corrected.What the catalog says now
byte[]over UDP; anIoBufferwith allowDefaultCodec=falsebyte[]over UDPRemoteFile, a stream with streamDownload, no body with download=falsebyte[]with stringPayload=false)any: the body is not sent; the acknowledgement comes from the CamelMllpAcknowledgement properties or autoAckManagerEventany: the action and its arguments are headersManagerResponseunknown: the return type of the IDLObject[]of the parameters, or the parameter with singleParameterObject[]or the single parameterunknown: the response of the protocolquickfix.Message, or no body for the session eventsunknown: what the peer serialized;Viewmessages with enableViewMessagesbyte[]Checked at runtime. Throwaway tests, not part of the PR, sent text, bytes, a stream, a file, a Map, a POJO, a number and no body. Every call stayed local. The setups:
Not run: cometds over TLS, the avro http transport, the jgroups-raft FOLLOWER event, and the asterisk error answer.
Choices
objectCodecPatternlists more classes, and the descriptions say so.unknownoutputs, as the IDL or the protocol decides the class.Doc fixes
byte[]payloads. By default the consumer gives a String.Key, and put an array of theKeyand theValue.PRs #28214, #28373 (camel-mina-sftp), #28360 (camel-avro-rpc) and #28378 (camel-quickfix) change code of these modules, but not their Endpoint classes or generated files.
Bugs found, not fixed here. Filed one JIRA per component: CAMEL-26182 (camel-mina), CAMEL-26183 (camel-mllp), CAMEL-26184 (camel-quickfix), CAMEL-26185 (camel-asterisk), CAMEL-26186 (camel-thrift), CAMEL-26187 (camel-grpc), CAMEL-26188 (camel-cometd), CAMEL-26189 (camel-jgroups-raft), CAMEL-26190 (camel-jgroups).
getOut()creates an empty message.[B@….Local checks
🤖 Generated with Claude Code