Repository navigation
Conversation
…apstruct, atom, rss, oaipmh, jcr, jt400, robotframework, citrus, spring-event and weather Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet-bot
reviewed
Oct 24, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Clean catalog enrichment batch: all 15 @BodyTypes annotations are accurate per source code, both JSON copies (catalog + component-local) match, and the 4 doc fixes are correct. Test pivot from weather → eip:split is valid — weather now has body types.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 250 of 707 tested, 19 compile-only — current: 251 all testedMaveniverse Scalpel detected 250 affected modules (current approach: 251). Skip-tests mode would test 250 modules (17 direct + 235 downstream), skip tests for 19 (generated code, meta-modules) Modules only in current approach (1)
Modules Scalpel would test (250)
Modules with tests skipped (19)
💡 Manual integration tests recommended:
Build reactor — dependencies compiled but only changed modules were tested (17 modules, 3m 57s total)Total reactor time: 3m 57s
Top 20 slowest modules:
|
davsclaus
added a commit
that referenced
this pull request
Oct 24, 2026
…tom, rss, weather and seven more components (#28417) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Contributor
Author
|
Merged to main as 039dbed (squashed with the other CAMEL-24961 body type groups, tested together locally). Claude Code on behalf of davsclaus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Code on behalf of davsclaus
This group adds the catalog body types (CAMEL-24961) for fifteen components: smb, stax, fop, flatpack, dfdl, mapstruct, atom, rss, oaipmh, jcr, jt400, robotframework, citrus, spring-event and weather. Each change is an
@BodyTypesannotation on the Endpoint, plus the JSON it generates and the catalog copy. Four doc pages had their body text corrected. With this group and the other open groups, every component in the catalog has body types.What the catalog says now
SmbFilewith the content; a stream with streamDownload; no body with download=falseSourceByteArrayOutputStreamof the PDF or PSnet.sf.flatpack.DataSet, at the current row with splitRowsDocument; aByteArrayOutputStreamfor UNPARSEItemper entry; a List of them with splitEntries=falseSyndFeedholding the one entry; the whole feed with splitEntries=falseany: the options and headers make the requestjavax.jcr.observation.Eventany: insert stores the headers; getById takes the id as textObject[]for a program callObject[]for a program callany, converted to text for${body}ApplicationEventany: an ApplicationEvent as is, else wrapped in aCamelEventanyChecked at runtime. Throwaway tests, not part of the PR, sent text, bytes, a stream, a file, a Map, a POJO and no body. The setups:
Not run: the jt400 queues and the output of a program call, which need a real IBM i (only the parameter handling was run).
Doc fixes
Itemor a List of them, not the old AbderaEntry.SyndFeed, not a List of entries.DataSet, not aDataSetList. The claim that it can always be read as a List is removed, and the page warns to convert it to a Map before an async step.Test change:
CatalogDocTestof camel-jbang-core used weather as its component without body types. It now uses the split EIP, as the catalog has no body types for EIPs. PR #28416 makes the same change inCatalogDocsTestfor ldif.PRs #28373 (camel-smb), #28355 (camel-flatpack) and the others that change these modules do not touch their Endpoint classes or generated files.
Bugs found, not fixed here. Filed one JIRA per component: CAMEL-26124 (camel-jt400), CAMEL-26125 (camel-jcr), CAMEL-26126 (camel-stax), CAMEL-26127 (camel-fop), CAMEL-26128 (camel-flatpack), CAMEL-26129 (camel-dfdl), CAMEL-26130 (camel-oaipmh), CAMEL-26131 (camel-weather), CAMEL-26132 (camel-rss), CAMEL-26133 (camel-robotframework), CAMEL-26134 (camel-test-citrus), CAMEL-26135 (camel-spring-event).
java.io.Fileor Path body fails.spring-event:bargot the event sent tospring-event:foo, and every consumer gets all the events of the Spring context.[123, 34, …], and a File as its path.currentwrites the latitude and longitude into the shared configuration, so every later query uses them.getOut(), so all the headers are lost.Local checks
🤖 Generated with Claude Code