Repository navigation
chore: camel-jbang - fix the SourceSizeTest failure on main: SourceTab.java is over 2000 lines - #28419
Conversation
…s opened move to a class of their own SourceTab.java grew to 2007 lines on main, over the 2000 of SourceSizeTest, which fails the build of every PR. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
|
🧪 CI tested the following changed modules:
🔁 1 test passed only after a retry on JDK 21 (1 retried attempt) Recovered flaky tests on JDK 21 (1)
🔬 Scalpel shadow comparison — Scalpel: 2 of 707 tested, 1 compile-only — current: 2 all testedMaveniverse Scalpel detected 2 affected modules (current approach: 2). Skip-tests mode would test 2 modules (1 direct + 1 downstream), skip tests for 1 (generated code, meta-modules) Modules Scalpel would test (2)
Modules with tests skipped (1)
All tested modules (3 modules, 29.4s total)Total reactor time: 29.4s
Top 20 slowest modules:
|
SourceTab.javahas 2007 lines on main after #28234 and 67e73b3, over the 2000 linesSourceSizeTestallows. That fails thebuild (21, false)job of every open PR that builds camel-jbang-plugin-tui:As the test asks, this moves code into a class of its own rather than raising the limit.
emptySourceLinesandlabel(what the Source pane shows before a file is opened, about 50 static lines) move to the newSourceEmptyLines.SourceTab.javanow has 1958 lines.OpenedProjectViewsTestcalls the new class. No change in behavior.Tested: all camel-jbang-plugin-tui tests pass locally (2238 run, 0 failures).
Claude Code on behalf of Claus Ibsen
🤖 Generated with Claude Code