Skip to content

chore: camel-jbang - fix the SourceSizeTest failure on main: SourceTab.java is over 2000 lines - #28419

Merged
davsclaus merged 1 commit into
mainfrom
quick-fix/tui-source-tab-size
Oct 24, 2026
Merged

davsclaus merged 1 commit into
mainfrom
quick-fix/tui-source-tab-size

Conversation

@davsclaus

Copy link
Copy Markdown
Contributor

SourceTab.java has 2007 lines on main after #28234 and 67e73b3, over the 2000 lines SourceSizeTest allows. That fails the build (21, false) job of every open PR that builds camel-jbang-plugin-tui:

Expecting empty but was: ["SourceTab.java has 2007 lines, over the limit: split it"]

As the test asks, this moves code into a class of its own rather than raising the limit. emptySourceLines and label (what the Source pane shows before a file is opened, about 50 static lines) move to the new SourceEmptyLines. SourceTab.java now has 1958 lines. OpenedProjectViewsTest calls the new class. No change in behavior.

Tested: all camel-jbang-plugin-tui tests pass locally (2238 run, 0 failures).

Claude Code on behalf of Claus Ibsen

🤖 Generated with Claude Code

…s opened move to a class of their own

SourceTab.java grew to 2007 lines on main, over the 2000 of SourceSizeTest, which fails the build of every PR.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
@davsclaus davsclaus added this to the 4.24.0 milestone Oct 24, 2026
@davsclaus davsclaus added the task label Oct 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions github-actions Bot added the dsl label Oct 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • dsl/camel-jbang/camel-jbang-plugin-tui

🔁 1 test passed only after a retry on JDK 21 (1 retried attempt)

Recovered flaky tests on JDK 21 (1)
Module Test Failed attempts First failure
dsl/camel-jbang/camel-jbang-plugin-tui LaunchManagerOutcomeTest.startedWhenTheStatusFileSaysSo 1 expected: null but was: LaunchOutcome[ok=false, log=null]

ℹ️ These tests did not fail the build. Surefire retried them and they passed.
Retries are enabled project-wide by surefire.rerunFailingTestsCount in parent/pom.xml.


🔬 Scalpel shadow comparison — Scalpel: 2 of 707 tested, 1 compile-only — current: 2 all tested

Maveniverse Scalpel detected 2 affected modules (current approach: 2).

Skip-tests mode would test 2 modules (1 direct + 1 downstream), skip tests for 1 (generated code, meta-modules)

Modules Scalpel would test (2)
  • camel-jbang-plugin-tui ← dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/SourceEmptyLines.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/SourceTab.java, dsl/camel-jbang/camel-jbang-plugin-tui/src/test/java/org/apache/camel/dsl/jbang/core/commands/tui/OpenedProjectViewsTest.java
  • camel-launcher-container ← downstream of org.apache.camel:camel-launcher
Modules with tests skipped (1)
  • camel-launcher

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

All tested modules (3 modules, 29.4s total)

Total reactor time: 29.4s

Module Duration Status
Camel :: Launcher 28.7s SUCCESS
Camel :: Launcher :: Container 0.8s SUCCESS
Camel :: JBang :: Plugin :: TUI n/a

Top 20 slowest modules:

  • Camel :: Launcher (28.7s)
  • Camel :: Launcher :: Container (0.8s)

⚙️ View full build and test results

@davsclaus
davsclaus merged commit a23cf11 into main Oct 24, 2026
6 checks passed
@davsclaus
davsclaus deleted the quick-fix/tui-source-tab-size branch October 24, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant