[DaanHoogland]

Normalize IPv6 addresses using InetAddress.getHostAddress() so that compressed forms like ::1 and full forms like 0:0:0:0:0:0:0:1 are treated as equivalent when checking the allowed IPs list.

Fixes #6714

(claude assisted fix)

Description

This PR...

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[DaanHoogland]

@Rubueno , you care to test this?

[codecov]

Codecov Report

❌ Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.78%. Comparing base (2d886b6) to head (1b4db1a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...oudstack/metrics/PrometheusExporterServerImpl.java	57.14%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #13245   +/-   ##
=========================================
  Coverage     20.77%   20.78%           
- Complexity    21923    21930    +7     
=========================================
  Files          6496     6496           
  Lines        591630   591656   +26     
  Branches      72591    72592    +1     
=========================================
+ Hits         122914   122957   +43     
+ Misses       455372   455355   -17     
  Partials      13344    13344           

Flag	Coverage Δ
uitests	3.88% <ø> (ø)
unittests	22.09% <57.14%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Rubueno]

@Rubueno , you care to test this?

I don't have a test env available right now, but reducing the change to a very minimal compiled program seems to render the expected output

Thanks Daan!

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19028

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-16856)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 60846 seconds
Marvin logs: [archive removed]
Smoke tests completed. 155 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	Failure	0.06	test_ssvm.py
test_04_cpvm_internals	Failure	0.07	test_ssvm.py

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

3 open issues

• InetAddress.getByName("") resolves to the loopback address on the JDK, so an empty allowlist… · New
• The allowlist is parsed and normalized on every HTTP request; additionally,… · New
• The warning drops the exception context, which makes troubleshooting harder (e.g., distinguishing… · New

_{Review effort: Lite}

[github-actions]

🔴 Test Coverage Grade: D — Marginal

Metric	Value
Line coverage	25.89%
Branch coverage	20.22%

Grade Scale

Grade	Line Coverage	Meaning
🟢 A	≥ 80%	Excellent - this code sleeps well at night 😴
🟡 B	60-79%	Good - almost there, don't stop now 😉
🟠 C	40-59%	Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D	20-39%	Marginal - boldly shipping where no test has gone before 🖖
⛔ F	< 20%	Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19879

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[DaanHoogland]

@nvazquez as seen in #13245 (comment), the logic was tested. I think this can merge with a review .. cc @NuxRo ;) ;)

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[NuxRo]

LGTM, good job Daan

[nvazquez]

Code LGTM

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
41.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud