Repository navigation
Remove awsapi leftovers - #13712
Remove awsapi leftovers#13712winterhazel wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13712 +/- ##
=========================================
Coverage 19.65% 19.65%
+ Complexity 19792 19790 -2
=========================================
Files 6368 6367 -1
Lines 574881 574807 -74
Branches 70351 70345 -6
=========================================
- Hits 112970 112957 -13
+ Misses 449639 449578 -61
Partials 12272 12272
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| -- Schema upgrade from 4.23.0.0 to 4.24.0.0 | ||
| --; | ||
|
|
||
| -- Remove leftovers from awsapi |
There was a problem hiding this comment.
does anything run this script yet? i dont see a 4.23 to 4.24 upgrade step on main, so should these lines go in the 4.22.1 to 4.23 script instead?
| @Param(description = "Path of the Domain the Account belongs to", since = "4.13") | ||
| private String domainPath; | ||
|
|
||
| @SerializedName(ApiConstants.DEFAULT_ZONE_ID) |
There was a problem hiding this comment.
should we tick breaking change here? anyone calling the mark default zone api or reading the default zone from list accounts will break after upgrade
| --; | ||
|
|
||
| -- Remove leftovers from awsapi | ||
| CALL `cloud`.`IDEMPOTENT_DROP_FOREIGN_KEY`('cloud.account', 'fk_account__default_zone_id'); |
There was a problem hiding this comment.
We have to move this to the correct file
Description
This PR removes a few leftovers from awsapi.
Column
default_zone_idwas added toaccountsolely for the integration, and is not used anymore. APImarkDefaultZoneForAccountwas created to set the value of this unused column.Types of changes
How Has This Been Tested?
Tests are still pending.