config cleanup

[DaanHoogland]

Description

This PR tries to get rid of the Config enum or the old mechanism to define configuration items, which is long overdue. The change should be transparent, but is huge so good regression testing is required. And merg early in the release cycle is recommended.
Commits are being done in batches for review convenience. They could have been done in separate PRs but in the end the changes are rather trivial.

Fixes: #10752

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[codecov]

Codecov Report

❌ Patch coverage is 41.70096% with 425 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.65%. Comparing base (1cd2491) to head (1866d9e).

Files with missing lines	Patch %	Lines
...java/com/cloud/server/ConfigurationServerImpl.java	0.00%	46 Missing ⚠️
.../cloud/resourcelimit/ResourceLimitManagerImpl.java	0.00%	31 Missing ⚠️
...oud/network/lb/ElasticLoadBalancerManagerImpl.java	5.55%	17 Missing ⚠️
.../cloud/configuration/ConfigurationManagerImpl.java	42.30%	13 Missing and 2 partials ⚠️
...ork/router/VirtualNetworkApplianceManagerImpl.java	0.00%	13 Missing ⚠️
...isor/xenserver/discoverer/XcpServerDiscoverer.java	0.00%	11 Missing ⚠️
...ava/com/cloud/network/NetworkUsageManagerImpl.java	0.00%	10 Missing ⚠️
...rc/main/java/com/cloud/usage/UsageServiceImpl.java	0.00%	10 Missing ⚠️
...oud/network/ExternalFirewallDeviceManagerImpl.java	0.00%	9 Missing ⚠️
...ain/java/com/cloud/network/NetworkServiceImpl.java	0.00%	9 Missing ⚠️
... and 100 more

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #13884   +/-   ##
=========================================
  Coverage     19.65%   19.65%           
- Complexity    19794    19818   +24     
=========================================
  Files          6368     6384   +16     
  Lines        574889   574887    -2     
  Branches      70353    70333   -20     
=========================================
+ Hits         112985   113014   +29     
+ Misses       449634   449599   -35     
- Partials      12270    12274    +4     

Flag	Coverage Δ
uitests	3.41% <ø> (ø)
unittests	20.93% <41.70%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🔴 Test Coverage Grade: D — Marginal

Metric	Value
Line coverage	24.51%
Branch coverage	18.70%

Grade Scale

Grade	Line Coverage	Meaning
🟢 A	≥ 80%	Excellent - this code sleeps well at night 😴
🟡 B	60-79%	Good - almost there, don't stop now 😉
🟠 C	40-59%	Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D	20-39%	Marginal - boldly shipping where no test has gone before 🖖
⛔ F	< 20%	Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[sonarqubecloud]

Quality Gate failed

Failed conditions
26.3% Coverage on New Code (required ≥ 40%)
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.