Add assignVolume API to the GUI by erikbocks · Pull Request #14215 · apache/cloudstack

erikbocks · 2026-09-21T18:06:36Z

Description

This PR implements support for the assignVolume API in the GUI.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Screenshots (if appropriate):

Action button in volume list view

Volume details page

Volume assignment form

How Has This Been Tested?

Created a volume and assigned it to other account.
Created a volume in a project and assigned it to another project.
Created a volume in an account and assigned it to a project.
Created a volume in a project and assigned it to an account.

codecov · 2026-09-21T18:16:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.91%. Comparing base (602d9ec) to head (c6e9984).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #14215      +/-   ##
============================================
- Coverage     19.91%   19.91%   -0.01%     
+ Complexity    20200    20196       -4     
============================================
  Files          6373     6374       +1     
  Lines        577230   577274      +44     
  Branches      70696    70702       +6     
============================================
- Hits         114974   114942      -32     
- Misses       449690   449765      +75     
- Partials      12566    12567       +1

Flag	Coverage Δ
uitests	`3.70% <ø> (-0.01%)`	⬇️
unittests	`21.18% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Copilot review overview

🟡 Changes recommended

Clear the stale selected account ID when no matching account is found before submitting an assignment.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Clear stale account ID when no account matches · New

What changed in this PR

Adds GUI support for assigning unattached volumes to accounts or projects via the assignVolume API.

Changes:

Adds the volume assignment form and API submission.
Registers the assignment action in storage views.
Extends ownership selection with account IDs.
Adds English and Portuguese localization strings.

File	Description
`ui/src/views/storage/AssignVolume.vue`	Volume assignment form and API call
`ui/src/views/compute/wizard/OwnershipSelection.vue`	Account ID selection support
`ui/src/config/section/storage.js`	Volume action registration
`ui/public/locales/pt_BR.json`	Portuguese localization
`ui/public/locales/en.json`	English labels and messages

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Copilot review overview

🟡 Changes recommended

Fix detached-volume action visibility and prevent duplicate ownership-change events.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Check virtualmachineid value before hiding assign action · New

Resolved since last review (1)

Clear stale account ID when no account matches

Previously missed (1)

In code that hasn't changed since last review

Avoid duplicate fetch-owner events during account initialization

ui/src/views/compute/wizard/OwnershipSelection.vue:227

handleSelectedAccountId already calls emitChangeEvent() at line 247, so invoking it here and then emitting again on line 227 produces two fetch-owner events whenever accounts are loaded. Consumers such as AssignInstance react by calling fetchNetworks(), resulting in duplicate network-list requests during initialization; emit only once for this path.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot review overview

🟡 Changes recommended

A critical stale-selection submission issue and a duplicate event remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Clear stale account selection during asynchronous refresh · New

Resolved since last review (1)

Check virtualmachineid value before hiding assign action

      selectedAccountType: this.$store.getters.project?.id ? 'Project' : 'Account',
      selectedDomain: null,
      selectedAccount: null,
+      selectedAccountId: null,


Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Damans227 · 2026-10-15T13:48:57Z

+          icon: 'user-add-outlined',
+          label: 'label.assign.volume.another',
+          dataView: true,
+          show: (record) => { return !record.virtualmachineid },


should we hide this for volumes in destroy state too? the owners count already went down when it was destroyed, so moving it takes it off a second time

Damans227 · 2026-10-15T13:48:58Z

+
+      if (this.selectedAccountType === 'Account') {
+        if (!this.selectedAccountId) {
+          this.accountError = true


should this show an error on the form? nothing reads this flag, so submit with no account picked just does nothing

Add API assignVolume to the GUI

9b9fb9e

Copilot AI lite review requested due to automatic review settings September 21, 2026 18:06

erikbocks changed the title ~~Add API assignVolume to the GUI~~ Add assignVolume API to the GUI Sep 21, 2026

Copilot started reviewing on behalf of erikbocks September 21, 2026 18:21

View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

Comment thread ui/src/views/compute/wizard/OwnershipSelection.vue Resolved

Address copilot review

b5bd1d3

Copilot AI review requested due to automatic review settings September 21, 2026 18:36

boring-cyborg Bot added the component:UI label Sep 21, 2026

Copilot started reviewing on behalf of erikbocks September 21, 2026 18:40

View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

Comment thread ui/src/config/section/storage.js Resolved

Make feature hidden only for attached volumes

063c9ae

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 21, 2026 18:46

Copilot started reviewing on behalf of erikbocks September 21, 2026 18:53

View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

Comment thread ui/src/views/compute/wizard/OwnershipSelection.vue

selectedAccountType: this.$store.getters.project?.id ? 'Project' : 'Account',

selectedDomain: null,

selectedAccount: null,

selectedAccountId: null,

erikbocks commented Sep 29, 2026

View reviewed changes

Comment thread ui/src/config/section/storage.js Resolved

Update ui/src/config/section/storage.js

c6e9984

Copilot AI lite review requested due to automatic review settings September 29, 2026 18:43

Copilot AI reviewed Sep 29, 2026

Damans227 reviewed Oct 15, 2026

View reviewed changes

Navigation Menu

Repository navigation

Add assignVolume API to the GUI - #14215

Add assignVolume API to the GUI#14215
erikbocks wants to merge 4 commits into
apache:mainfrom
scclouds:add-assignvolume-to-ui

erikbocks commented Sep 21, 2026

Uh oh!

codecov Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Damans227 Oct 15, 2026

Uh oh!

Damans227 Oct 15, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

erikbocks commented Sep 21, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

codecov Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Damans227 Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

Damans227 Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Sep 21, 2026 •

edited

Loading