Skip to content

enabling resize volume Api validation notification errors to be shown in UI #14220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sathvikaragi wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −5
Open

enabling resize volume Api validation notification errors to be shown in UI #14220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ui/src/views/storage/ResizeVolume.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,7 @@ export default {
})
this.closeModal()
}).catch(error => {
this.$notification.error({
message: `${this.$t('label.error')} ${error.response.status}`,
description: error.response.data.errorresponse.errortext,
duration: 0
})
this.$notifyError(error)

@Damans227 Damans227 Oct 14, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we fix the other forms too? pod, host, cluster, ip range and a few more still read the error the old way, so they probably hide it the same way

@sathvikaragi sathvikaragi Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, those other forms are likely hiding the error the same way. I propose we scope this PR to the current form changes and do the rest in subsequent PR. I hope that is okay with you.

@Damans227 Damans227 Oct 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thats fine.

@sathvikaragi sathvikaragi Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou so much for understanding and quick response!

}).finally(() => {
this.loading = false
})
Expand Down
Loading