Skip to content

Addition of a button to download backup's validation screenshot in UI - #14234

Open
GeanJair wants to merge 1 commit into
apache:mainfrom
scclouds:add-button-to-download-screenshot
Open

GeanJair wants to merge 1 commit into
apache:mainfrom
scclouds:add-button-to-download-screenshot

Conversation

@GeanJair

Copy link
Copy Markdown
Contributor

Description

The downloadValidationScreenshot API allows to perform the download of backups validation screenshot; However, it is not possible to use it in the GUI. Changes were made to allow the user to download the backups validation screenshot via GUI.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

Steps to download the validation screenshot

image

image

image

image

How Has This Been Tested?

  • Verified that was possible to download the validation screenshot via UI.
  • Verified that the button was only rendered when the backup status was in the BackedUp state and the validation status was Valid.

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.91%. Comparing base (602d9ec) to head (590ac94).
⚠️ Report is 53 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14234      +/-   ##
============================================
- Coverage     19.91%   19.91%   -0.01%     
  Complexity    20200    20200              
============================================
  Files          6373     6373              
  Lines        577230   577237       +7     
  Branches      70696    70696              
============================================
- Hits         114974   114954      -20     
- Misses       449690   449717      +27     
  Partials      12566    12566              
Flag Coverage Δ
uitests 3.70% <ø> (-0.01%) ⬇️
unittests 21.18% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

icon: 'picture-outlined',
label: 'label.action.download.screenshot',
message: 'message.action.download.screenshot',
dataView: true,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this only show for Valid or NotValid? backups from other providers have no validation status, so the button shows there and the download always fails

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants