Option to create StorPool primary storage with a valid URL by slavkap · Pull Request #8356 · apache/cloudstack

slavkap · 2023-12-14T09:12:08Z

Description

This PR provides another option to create StorPool primary storage with a valid URL in cases the old format is not accepted. The user will be able to use the old and new format

Old format SP_API_HTTP=address:port;SP_AUTH_TOKEN=token;SP_TEMPLATE=template_name
New format storpool://{SP_AUTH_TOKEN}@{SP_API_HTTP}:{SP_API_HTTP_PORT}/{SP_TEMPLATE}

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

How Has This Been Tested?

Manual and smoke tests

codecov · 2023-12-14T09:20:02Z

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (6d916ca) 30.85% compared to head (0dc7e54) 30.76%.
Report is 4 commits behind head on main.

Files	Patch %	Lines
...loudstack/storage/datastore/util/StorPoolUtil.java	0.00%	11 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8356      +/-   ##
============================================
- Coverage     30.85%   30.76%   -0.10%     
+ Complexity    34048    33963      -85     
============================================
  Files          5341     5341              
  Lines        374861   374872      +11     
  Branches      54518    54519       +1     
============================================
- Hits         115659   115322     -337     
- Misses       243973   244363     +390     
+ Partials      15229    15187      -42

Flag	Coverage Δ
simulator-marvin-tests	`24.65% <0.00%> (-0.11%)`	⬇️
uitests	`4.39% <ø> (ø)`
unit-tests	`16.46% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

weizhouapache

code lgtm

DaanHoogland

clgtm

harikrishna-patnala

CLGTM

@blueorangutan package

shwstppr

Code LGTM

DaanHoogland · 2023-12-20T07:57:50Z

@blueorangutan package

blueorangutan · 2023-12-20T07:58:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-12-20T10:12:23Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8099

DaanHoogland · 2023-12-20T12:20:30Z

@blueorangutan test alma9 kvm-alma9

blueorangutan · 2023-12-20T12:22:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

blueorangutan · 2023-12-21T03:25:12Z

[SF] Trillian test result (tid-8647)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 52392 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8356-t8647-kvm-alma9.zip
Smoke tests completed. 125 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_destroy_ssvm	`Failure`	918.66	test_ssvm.py
test_05_list_volumes_isrecursive	`Failure`	0.04	test_list_volumes.py
test_07_list_volumes_listall	`Failure`	0.04	test_list_volumes.py
test_01_migrate_VM_and_root_volume	`Error`	91.61	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	51.02	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	46.12	test_vm_life_cycle.py

With this change, a fix is added for failures seen with test_08_migrate_vm or other migration-related tests because the target host is in `Connecting` state, #8356 (comment) #8374 (comment) and more

sureshanaparti

code lgtm

sureshanaparti · 2023-12-25T10:28:12Z

@blueorangutan package

blueorangutan · 2023-12-25T10:30:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-12-25T11:33:55Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8140

sureshanaparti · 2023-12-25T12:37:12Z

@blueorangutan test alma9 kvm-alma9

blueorangutan · 2023-12-25T12:38:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

blueorangutan · 2023-12-25T23:43:00Z

[SF] Trillian test result (tid-8681)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 37980 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8356-t8681-kvm-alma9.zip
Smoke tests completed. 111 look OK, 10 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
test_01_migrate_VM_and_root_volume	`Error`	1.36	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	1.42	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	0.02	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	0.02	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	0.02	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	0.02	test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup	`Error`	4.34	test_vm_life_cycle.py
ContextSuite context=TestVMSchedule>:setup	`Error`	0.00	test_vm_schedule.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	4.20	test_vm_snapshots.py
test_04_deploy_vnf_appliance	`Error`	93.92	test_vnf_templates.py
test_04_deploy_vnf_appliance	`Error`	93.93	test_vnf_templates.py
test_05_delete_vnf_template	`Error`	0.07	test_vnf_templates.py
ContextSuite context=TestVnfTemplates>:teardown	`Error`	0.16	test_vnf_templates.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
test_01_root_volume_encryption	`Error`	0.02	test_volumes.py
test_02_data_volume_encryption	`Error`	0.02	test_volumes.py
test_03_root_and_data_volume_encryption	`Error`	0.02	test_volumes.py
ContextSuite context=TestVolumes>:setup	`Error`	5.53	test_volumes.py
test_01_verify_ipv6_vpc	`Error`	3.47	test_vpc_ipv6.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	6.59	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	5.30	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	5.68	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	5.36	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	5.20	test_vpc_redundant.py
test_01_VPC_nics_after_destroy	`Error`	5.53	test_vpc_router_nics.py
test_02_VPC_default_routes	`Error`	5.45	test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn	`Failure`	3.52	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Failure`	3.42	test_vpc_vpn.py
test_01_vpc_remote_access_vpn	`Failure`	1.18	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Failure`	3.49	test_vpc_vpn.py
test_01_cancel_host_maintenace_with_no_migration_jobs	`Error`	0.07	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	0.06	test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure	`Error`	0.06	test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected	`Error`	0.02	test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected	`Error`	0.02	test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected	`Error`	0.02	test_host_maintenance.py

) With this change, a fix is added for failures seen with test_08_migrate_vm or other migration-related tests because the target host is in `Connecting` state, apache#8356 (comment) apache#8374 (comment) and more

yadvr · 2024-02-05T08:51:10Z

LGTM - merging based on github actions and that all changes in storpool specific plugin.

* Option to create primary storage with a valid URL * check if the scheme is valid

boring-cyborg Bot added component:primary-storage component:storage labels Dec 14, 2023

weizhouapache approved these changes Dec 14, 2023

View reviewed changes

DaanHoogland approved these changes Dec 14, 2023

View reviewed changes

harikrishna-patnala approved these changes Dec 15, 2023

View reviewed changes

sureshanaparti reviewed Dec 19, 2023

View reviewed changes

Comment thread ...volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolUtil.java

shwstppr approved these changes Dec 20, 2023

View reviewed changes

DaanHoogland added the has-3rdparty-components label Dec 20, 2023

DaanHoogland added the status:ready-for-merge label Dec 21, 2023

shwstppr mentioned this pull request Dec 21, 2023

test: additional check to ensure hosts are left in up state #8383

Merged

13 tasks

slavkap added 2 commits December 21, 2023 16:14

Option to create primary storage with a valid URL

4589e64

check if the scheme is valid

0dc7e54

slavkap force-pushed the sp-valid-url branch from 8df9180 to 0dc7e54 Compare December 21, 2023 14:51

sureshanaparti approved these changes Dec 22, 2023

View reviewed changes

yadvr changed the base branch from main to 4.19 February 5, 2024 08:50

yadvr added this to the 4.19.1.0 milestone Feb 5, 2024

yadvr merged commit 94c8b1d into apache:4.19 Feb 5, 2024

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Feb 7, 2024

Option to create StorPool primary storage with a valid URL (apache#8356)

cf573ec

* Option to create primary storage with a valid URL * check if the scheme is valid

sureshanaparti added the 3rd-party:storpool label Jul 18, 2024

DaanHoogland removed the status:ready-for-merge label Dec 4, 2024

Conversation

slavkap commented Dec 14, 2023

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

How Has This Been Tested?

Uh oh!

codecov Bot commented Dec 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Dec 20, 2023

Uh oh!

blueorangutan commented Dec 20, 2023

Uh oh!

blueorangutan commented Dec 20, 2023

Uh oh!

DaanHoogland commented Dec 20, 2023

Uh oh!

blueorangutan commented Dec 20, 2023

Uh oh!

blueorangutan commented Dec 21, 2023

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Dec 25, 2023

Uh oh!

blueorangutan commented Dec 25, 2023

Uh oh!

blueorangutan commented Dec 25, 2023

Uh oh!

sureshanaparti commented Dec 25, 2023

Uh oh!

blueorangutan commented Dec 25, 2023

Uh oh!

blueorangutan commented Dec 25, 2023

Uh oh!

yadvr commented Feb 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov Bot commented Dec 14, 2023 •

edited

Loading