Fix listStoragePoolsMetricsCmd

[vishesh92]

Description

This PR fixes listStoragePoolsMetricsCmd when there are no search results.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

To reproduce the error

cmk list storagepoolsmetrics keyword=zxcvbn
__ Error: (HTTP 530, error code 4250) DB Exception on: com.mysql.cj.jdbc.ClientPreparedStatement: SELECT cluster.id, cluster.name, cluster.guid, cluster.data_center_id, cluster.pod_id, cluster.hypervisor_type, cluster.cluster_type, cluster.allocation_state, cluster.managed_state, cluster.removed, cluster.uuid FROM cluster WHERE cluster.uuid IN )  AND cluster.removed IS NULL 

After applying the patch, error disappears.

How did you try to break this feature and the system with this change?

[vishesh92]

@blueorangutan package

[blueorangutan]

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 30.90%. Comparing base (c25264b) to head (95f9d4b).

Files	Patch %	Lines
...c/main/java/com/cloud/utils/db/GenericDaoBase.java	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #8885      +/-   ##
============================================
- Coverage     30.98%   30.90%   -0.08%     
+ Complexity    34408    34320      -88     
============================================
  Files          5359     5359              
  Lines        377017   377019       +2     
  Branches      54856    54856              
============================================
- Hits         116804   116518     -286     
- Misses       244852   245090     +238     
- Partials      15361    15411      +50     

Flag	Coverage Δ
simulator-marvin-tests	24.72% <0.00%> (-0.09%)	⬇️
uitests	4.37% <ø> (ø)
unit-tests	16.58% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9166

[vishesh92]

@blueorangutan test

[blueorangutan]

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[sureshanaparti]

code lgtm

[blueorangutan]

[SF] Trillian test result (tid-9719)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50725 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8885-t9719-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

clgtm

[borisstoyanov]

LGTM, manually tested