Skip to content

Fix sonar cloud warnings and get a green quality build on RAT - #730

Merged
Claudenw merged 5 commits into
masterfrom
fix/reduceSonarWarnings
Sep 19, 2026
Merged

Claudenw merged 5 commits into
masterfrom
fix/reduceSonarWarnings

Conversation

@ottlinger

@ottlinger ottlinger commented Sep 17, 2026

Copy link
Copy Markdown
Contributor
  • Remove debugging var usage in test
  • Use java.time instead of java.date
  • NOSONAR for Injection in MOJO
  • ThreadLocal cleanup ?! remove() cannot be called within the class itself

@ottlinger

Copy link
Copy Markdown
Contributor Author

@claude do you have an idea if we can apply the sonar warning to cally destroy on the ThreadLocal object? I guess we should add a NOSONAR for it, but just want to make sure.

@ottlinger
ottlinger marked this pull request as ready for review September 18, 2026 08:51
@ottlinger ottlinger changed the title WIP: Fix sonar cloud warnings and get a green quality build on RAT Fix sonar cloud warnings and get a green quality build on RAT Sep 18, 2026
@ottlinger
ottlinger requested a review from Claudenw September 18, 2026 08:51
@sonarqubecloud

Copy link
Copy Markdown

@Claudenw Claudenw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Claudenw
Claudenw merged commit ef96ca4 into master Sep 19, 2026
15 checks passed
@Claudenw
Claudenw deleted the fix/reduceSonarWarnings branch September 19, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants