Repository navigation
fix: enable tracing with the scheduler's rest-api feature - #2747
Merged
Merged
Conversation
The REST handlers and the event-log history log through `tracing`, which only the default `build-binary` feature enabled, so building ballista-scheduler with `--no-default-features --features rest-api` failed with 18 unresolved `tracing` errors. `rest-api` now enables `tracing`, and CI checks that build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue filed; the bug is described below. Related: #2745, which proposes compiling the event-log writer without the REST API.
Rationale for this change
ballista-schedulerdoesn't compile with--no-default-features --features rest-api:The REST handlers (
src/api/handlers.rs) and the event-log history (src/history/mod.rs) log throughtracing, which is an optional dependency. Only the defaultbuild-binaryfeature enabled it, so the default build hid the problem. An embedder that turns off the default features and asks forrest-api, for example to get the event-log writer, can't build. Apache DataFusion Comet hit this in apache/datafusion-comet#7420 and works around it by enablingtracingitself.What changes are included in this PR?
rest-apifeature enablestracing.--no-default-featuresCI job also checks the scheduler with onlyrest-apienabled.Are there any user-facing changes?
No. Builds that already compiled are unchanged.
ballista-schedulerwith--no-default-features --features rest-apinow compiles.